* [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration
@ 2018-07-25 9:55 Anders Roxell
2018-07-25 10:09 ` Ingo Molnar
2018-07-25 14:37 ` [tip:x86/mm] arm/asm/tlb.h: " tip-bot for Anders Roxell
0 siblings, 2 replies; 3+ messages in thread
From: Anders Roxell @ 2018-07-25 9:55 UTC (permalink / raw)
To: riel, peterz, mingo, songliubraving, linux, dave.hansen, x86
Cc: linux-arm-kernel, linux-kernel, Anders Roxell
Building on arm 32 with LPAE enabled we don't include asm-generic/tlb.h,
where we have tlb_flush_remove_tables_local and tlb_flush_remove_tables
defined.
mm/memory.c: In function ‘tlb_remove_table_smp_sync’:
mm/memory.c:339:2: error: implicit declaration of function ‘tlb_flush_remove_tables_local’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration]
tlb_flush_remove_tables_local(mm);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tlb_remove_table
mm/memory.c: In function ‘tlb_table_flush’:
mm/memory.c:372:2: error: implicit declaration of function ‘tlb_flush_remove_tables’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration]
tlb_flush_remove_tables(tlb->mm);
^~~~~~~~~~~~~~~~~~~~~~~
tlb_remove_table
To fix this issue we define them in arm 32's specific asm/tlb.h file.
Fixes: 2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
Ingo, would it make sense for you to pick it up into the x86 tree since
that contains the bug ?
Cheers,
Anders
arch/arm/include/asm/tlb.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h
index d5562f9ce600..f854148c8d7c 100644
--- a/arch/arm/include/asm/tlb.h
+++ b/arch/arm/include/asm/tlb.h
@@ -292,5 +292,13 @@ static inline void tlb_remove_check_page_size_change(struct mmu_gather *tlb,
{
}
+static inline void tlb_flush_remove_tables(struct mm_struct *mm)
+{
+}
+
+static inline void tlb_flush_remove_tables_local(void *arg)
+{
+}
+
#endif /* CONFIG_MMU */
#endif
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration
2018-07-25 9:55 [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration Anders Roxell
@ 2018-07-25 10:09 ` Ingo Molnar
2018-07-25 14:37 ` [tip:x86/mm] arm/asm/tlb.h: " tip-bot for Anders Roxell
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2018-07-25 10:09 UTC (permalink / raw)
To: Anders Roxell
Cc: riel, peterz, songliubraving, linux, dave.hansen, x86,
linux-arm-kernel, linux-kernel
* Anders Roxell <anders.roxell@linaro.org> wrote:
> Building on arm 32 with LPAE enabled we don't include asm-generic/tlb.h,
> where we have tlb_flush_remove_tables_local and tlb_flush_remove_tables
> defined.
> mm/memory.c: In function ‘tlb_remove_table_smp_sync’:
> mm/memory.c:339:2: error: implicit declaration of function ‘tlb_flush_remove_tables_local’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration]
> tlb_flush_remove_tables_local(mm);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tlb_remove_table
> mm/memory.c: In function ‘tlb_table_flush’:
> mm/memory.c:372:2: error: implicit declaration of function ‘tlb_flush_remove_tables’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration]
> tlb_flush_remove_tables(tlb->mm);
> ^~~~~~~~~~~~~~~~~~~~~~~
> tlb_remove_table
>
> To fix this issue we define them in arm 32's specific asm/tlb.h file.
>
> Fixes: 2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>
> Ingo, would it make sense for you to pick it up into the x86 tree since
> that contains the bug ?
Done and sorry about that! Will push your fix out to -next as well ASAP.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/mm] arm/asm/tlb.h: Fix build error implicit func declaration
2018-07-25 9:55 [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration Anders Roxell
2018-07-25 10:09 ` Ingo Molnar
@ 2018-07-25 14:37 ` tip-bot for Anders Roxell
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Anders Roxell @ 2018-07-25 14:37 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, anders.roxell, peterz, hpa, mingo, linux-kernel, torvalds
Commit-ID: 063daa8129f94d651c4d30a8333b577c5bbf8090
Gitweb: https://git.kernel.org/tip/063daa8129f94d651c4d30a8333b577c5bbf8090
Author: Anders Roxell <anders.roxell@linaro.org>
AuthorDate: Wed, 25 Jul 2018 11:55:57 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 25 Jul 2018 12:09:09 +0200
arm/asm/tlb.h: Fix build error implicit func declaration
Building on arm 32 with LPAE enabled we don't include asm-generic/tlb.h,
where we have tlb_flush_remove_tables_local and tlb_flush_remove_tables
defined.
The build fails with:
mm/memory.c: In function ‘tlb_remove_table_smp_sync’:
mm/memory.c:339:2: error: implicit declaration of function ‘tlb_flush_remove_tables_local’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration]
...
This bug got introduced in:
2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time")
To fix this issue we define them in arm 32's specific asm/tlb.h file as well.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dave.hansen@intel.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux@armlinux.org.uk
Cc: riel@surriel.com
Cc: songliubraving@fb.com
Fixes: 2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time")
Link: http://lkml.kernel.org/r/20180725095557.19668-1-anders.roxell@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/arm/include/asm/tlb.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h
index d5562f9ce600..f854148c8d7c 100644
--- a/arch/arm/include/asm/tlb.h
+++ b/arch/arm/include/asm/tlb.h
@@ -292,5 +292,13 @@ static inline void tlb_remove_check_page_size_change(struct mmu_gather *tlb,
{
}
+static inline void tlb_flush_remove_tables(struct mm_struct *mm)
+{
+}
+
+static inline void tlb_flush_remove_tables_local(void *arg)
+{
+}
+
#endif /* CONFIG_MMU */
#endif
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-25 14:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 9:55 [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration Anders Roxell
2018-07-25 10:09 ` Ingo Molnar
2018-07-25 14:37 ` [tip:x86/mm] arm/asm/tlb.h: " tip-bot for Anders Roxell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).