* [PATCH] perf trace: Fix summary_only option
@ 2015-03-19 18:23 David Ahern
2015-03-20 14:02 ` Arnaldo Carvalho de Melo
2015-03-22 10:15 ` [tip:perf/core] " tip-bot for David Ahern
0 siblings, 2 replies; 3+ messages in thread
From: David Ahern @ 2015-03-19 18:23 UTC (permalink / raw)
To: acme; +Cc: linux-kernel, David Ahern
The intent of the -s/--summary-only option is to just show a summary of the
system calls and statistics without any of the individual events. Commit
e596663ebb2 broke that by showing the interrupted lines:
perf trace -i perf.data -s
...
0.741 ( 0.000 ms): sleep/31316 fstat(fd: 4, statbuf: 0x7ffc75ceb830 ) ...
0.744 ( 0.000 ms): sleep/31316 mmap(len: 100244, prot: READ, flags: PRIVATE, fd: 4 ) ...
0.747 ( 0.000 ms): perf/31315 write(fd: 3, buf: 0x7d4bb0, count: 8 ) ...
...
Fix by checking for the summary only option.
Signed-off-by: David Ahern <dsahern@gmail.com>
---
tools/perf/builtin-trace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 6969ba98ff2f..dcd950ef2fd7 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1724,7 +1724,8 @@ static int trace__sys_enter(struct trace *trace, struct perf_evsel *evsel,
return -1;
}
- printed += trace__printf_interrupted_entry(trace, sample);
+ if (!trace->summary_only)
+ printed += trace__printf_interrupted_entry(trace, sample);
ttrace->entry_time = sample->time;
msg = ttrace->entry_str;
--
2.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf trace: Fix summary_only option
2015-03-19 18:23 [PATCH] perf trace: Fix summary_only option David Ahern
@ 2015-03-20 14:02 ` Arnaldo Carvalho de Melo
2015-03-22 10:15 ` [tip:perf/core] " tip-bot for David Ahern
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-03-20 14:02 UTC (permalink / raw)
To: David Ahern; +Cc: linux-kernel
Em Thu, Mar 19, 2015 at 12:23:03PM -0600, David Ahern escreveu:
> The intent of the -s/--summary-only option is to just show a summary of the
> system calls and statistics without any of the individual events. Commit
> e596663ebb2 broke that by showing the interrupted lines:
>
> perf trace -i perf.data -s
> ...
> 0.741 ( 0.000 ms): sleep/31316 fstat(fd: 4, statbuf: 0x7ffc75ceb830 ) ...
> 0.744 ( 0.000 ms): sleep/31316 mmap(len: 100244, prot: READ, flags: PRIVATE, fd: 4 ) ...
> 0.747 ( 0.000 ms): perf/31315 write(fd: 3, buf: 0x7d4bb0, count: 8 ) ...
> ...
>
> Fix by checking for the summary only option.
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/core] perf trace: Fix summary_only option
2015-03-19 18:23 [PATCH] perf trace: Fix summary_only option David Ahern
2015-03-20 14:02 ` Arnaldo Carvalho de Melo
@ 2015-03-22 10:15 ` tip-bot for David Ahern
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for David Ahern @ 2015-03-22 10:15 UTC (permalink / raw)
To: linux-tip-commits; +Cc: acme, linux-kernel, hpa, tglx, mingo, dsahern
Commit-ID: 13f22a2d4a5359867aa05562fc922f1ca24873a5
Gitweb: http://git.kernel.org/tip/13f22a2d4a5359867aa05562fc922f1ca24873a5
Author: David Ahern <dsahern@gmail.com>
AuthorDate: Thu, 19 Mar 2015 12:23:03 -0600
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Sat, 21 Mar 2015 14:53:31 -0300
perf trace: Fix summary_only option
The intent of the -s/--summary-only option is to just show a summary of
the system calls and statistics without any of the individual events.
Commit e596663ebb2 broke that by showing the interrupted lines:
perf trace -i perf.data -s
...
0.741 ( 0.000 ms): sleep/31316 fstat(fd: 4, statbuf: 0x7ffc75ceb830 ) ...
0.744 ( 0.000 ms): sleep/31316 mmap(len: 100244, prot: READ, flags: PRIVATE, fd: 4 ) ...
0.747 ( 0.000 ms): perf/31315 write(fd: 3, buf: 0x7d4bb0, count: 8 ) ...
...
Fix by checking for the summary only option.
Signed-off-by: David Ahern <dsahern@gmail.com>
Link: http://lkml.kernel.org/r/1426789383-19023-1-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-trace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 0b3b4e4..6af6bce 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1724,7 +1724,8 @@ static int trace__sys_enter(struct trace *trace, struct perf_evsel *evsel,
return -1;
}
- printed += trace__printf_interrupted_entry(trace, sample);
+ if (!trace->summary_only)
+ printed += trace__printf_interrupted_entry(trace, sample);
ttrace->entry_time = sample->time;
msg = ttrace->entry_str;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-22 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-19 18:23 [PATCH] perf trace: Fix summary_only option David Ahern
2015-03-20 14:02 ` Arnaldo Carvalho de Melo
2015-03-22 10:15 ` [tip:perf/core] " tip-bot for David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).