* [PATCH v2] x86/intel_rdt: Show missing resctrl mount options
@ 2018-09-12 23:48 Fenghua Yu
2018-10-03 14:22 ` [tip:x86/cache] " tip-bot for Xiaochen Shen
2018-10-03 19:58 ` tip-bot for Xiaochen Shen
0 siblings, 2 replies; 3+ messages in thread
From: Fenghua Yu @ 2018-09-12 23:48 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H Peter Anvin, Tony Luck
Cc: linux-kernel, x86, Xiaochen Shen, Fenghua Yu
From: Xiaochen Shen <xiaochen.shen@intel.com>
In resctrl filesystem, we have some mount options to enable
L3/L2 CDP and MBA Software Controller features if platform supports them:
mount -t resctrl resctrl [-o cdp[,cdpl2][,mba_MBps]] /sys/fs/resctrl
But currently only "cdp" option can be displayed. "cdpl2" and "mba_MBps"
options are not showed even when they are active mount options.
Before this patch:
#mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
#grep resctrl /proc/mounts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp 0 0
After this patch:
#mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
#grep resctrl /proc/mountts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp,mba_MBps 0 0
Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index b799c00bef09..82459a41fa84 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -2760,6 +2760,13 @@ static int rdtgroup_show_options(struct seq_file *seq, struct kernfs_root *kf)
{
if (rdt_resources_all[RDT_RESOURCE_L3DATA].alloc_enabled)
seq_puts(seq, ",cdp");
+
+ if (rdt_resources_all[RDT_RESOURCE_L2DATA].alloc_enabled)
+ seq_puts(seq, ",cdpl2");
+
+ if (is_mba_sc(&rdt_resources_all[RDT_RESOURCE_MBA]))
+ seq_puts(seq, ",mba_MBps");
+
return 0;
}
--
2.19.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:x86/cache] x86/intel_rdt: Show missing resctrl mount options
2018-09-12 23:48 [PATCH v2] x86/intel_rdt: Show missing resctrl mount options Fenghua Yu
@ 2018-10-03 14:22 ` tip-bot for Xiaochen Shen
2018-10-03 19:58 ` tip-bot for Xiaochen Shen
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Xiaochen Shen @ 2018-10-03 14:22 UTC (permalink / raw)
To: linux-tip-commits
Cc: tony.luck, linux-kernel, fenghua.yu, tglx, xiaochen.shen, mingo, hpa
Commit-ID: 32ece95d3052e0778eab98fd9c2ffde92c599ce9
Gitweb: https://git.kernel.org/tip/32ece95d3052e0778eab98fd9c2ffde92c599ce9
Author: Xiaochen Shen <xiaochen.shen@intel.com>
AuthorDate: Wed, 12 Sep 2018 16:48:38 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 3 Oct 2018 16:19:36 +0200
x86/intel_rdt: Show missing resctrl mount options
In resctrl filesystem, mount options exist to enable L3/L2 CDP and MBA
Software Controller features if the platform supports them:
mount -t resctrl resctrl [-o cdp[,cdpl2][,mba_MBps]] /sys/fs/resctrl
But currently only "cdp" option is displayed in /proc/mounts. "cdpl2" and
"mba_MBps" options are not shown even when they are active.
Before:
# mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
# grep resctrl /proc/mounts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp 0 0
After:
# mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
# grep resctrl /proc/mounts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp,mba_MBps 0 0
Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "H Peter Anvin" <hpa@zytor.com>
Cc: "Tony Luck" <tony.luck@intel.com>
Link: https://lkml.kernel.org/r/1536796118-60135-1-git-send-email-fenghua.yu@intel.com
---
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index 1b8e86a5d5e1..82a487840eb2 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -2795,6 +2795,13 @@ static int rdtgroup_show_options(struct seq_file *seq, struct kernfs_root *kf)
{
if (rdt_resources_all[RDT_RESOURCE_L3DATA].alloc_enabled)
seq_puts(seq, ",cdp");
+
+ if (rdt_resources_all[RDT_RESOURCE_L2DATA].alloc_enabled)
+ seq_puts(seq, ",cdpl2");
+
+ if (is_mba_sc(&rdt_resources_all[RDT_RESOURCE_MBA]))
+ seq_puts(seq, ",mba_MBps");
+
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:x86/cache] x86/intel_rdt: Show missing resctrl mount options
2018-09-12 23:48 [PATCH v2] x86/intel_rdt: Show missing resctrl mount options Fenghua Yu
2018-10-03 14:22 ` [tip:x86/cache] " tip-bot for Xiaochen Shen
@ 2018-10-03 19:58 ` tip-bot for Xiaochen Shen
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Xiaochen Shen @ 2018-10-03 19:58 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, fenghua.yu, xiaochen.shen, tony.luck, linux-kernel, hpa, mingo
Commit-ID: 2cc81c6992248ea37d0241bc325977bab310bc3b
Gitweb: https://git.kernel.org/tip/2cc81c6992248ea37d0241bc325977bab310bc3b
Author: Xiaochen Shen <xiaochen.shen@intel.com>
AuthorDate: Wed, 12 Sep 2018 16:48:38 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 3 Oct 2018 21:53:49 +0200
x86/intel_rdt: Show missing resctrl mount options
In resctrl filesystem, mount options exist to enable L3/L2 CDP and MBA
Software Controller features if the platform supports them:
mount -t resctrl resctrl [-o cdp[,cdpl2][,mba_MBps]] /sys/fs/resctrl
But currently only "cdp" option is displayed in /proc/mounts. "cdpl2" and
"mba_MBps" options are not shown even when they are active.
Before:
# mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
# grep resctrl /proc/mounts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp 0 0
After:
# mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
# grep resctrl /proc/mounts
/sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp,mba_MBps 0 0
Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "H Peter Anvin" <hpa@zytor.com>
Cc: "Tony Luck" <tony.luck@intel.com>
Link: https://lkml.kernel.org/r/1536796118-60135-1-git-send-email-fenghua.yu@intel.com
---
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index 1b8e86a5d5e1..82a487840eb2 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -2795,6 +2795,13 @@ static int rdtgroup_show_options(struct seq_file *seq, struct kernfs_root *kf)
{
if (rdt_resources_all[RDT_RESOURCE_L3DATA].alloc_enabled)
seq_puts(seq, ",cdp");
+
+ if (rdt_resources_all[RDT_RESOURCE_L2DATA].alloc_enabled)
+ seq_puts(seq, ",cdpl2");
+
+ if (is_mba_sc(&rdt_resources_all[RDT_RESOURCE_MBA]))
+ seq_puts(seq, ",mba_MBps");
+
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-03 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 23:48 [PATCH v2] x86/intel_rdt: Show missing resctrl mount options Fenghua Yu
2018-10-03 14:22 ` [tip:x86/cache] " tip-bot for Xiaochen Shen
2018-10-03 19:58 ` tip-bot for Xiaochen Shen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).