* [patch] perf.data documentation has wrong units for memory size
@ 2019-07-25 15:57 Vince Weaver
2019-07-27 17:15 ` Jiri Olsa
2019-07-29 21:35 ` [tip:perf/urgent] perf tools: Fix perf.data documentation " tip-bot for Vince Weaver
0 siblings, 2 replies; 3+ messages in thread
From: Vince Weaver @ 2019-07-25 15:57 UTC (permalink / raw)
To: linux-kernel
Cc: Arnaldo Carvalho de Melo, Peter Zijlstra, Ingo Molnar,
Alexander Shishkin, Jiri Olsa, Namhyung Kim
The perf.data-file-format documentation incorrectly says the
HEADER_TOTAL_MEM results are in bytes. The results are in kilobytes
(perf reads the value from /proc/meminfo)
Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
index 5f54feb19977..d030c87ed9f5 100644
--- a/tools/perf/Documentation/perf.data-file-format.txt
+++ b/tools/perf/Documentation/perf.data-file-format.txt
@@ -126,7 +126,7 @@ vendor,family,model,stepping. For example: GenuineIntel,6,69,1
HEADER_TOTAL_MEM = 10,
-An uint64_t with the total memory in bytes.
+An uint64_t with the total memory in kilobytes.
HEADER_CMDLINE = 11,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] perf.data documentation has wrong units for memory size
2019-07-25 15:57 [patch] perf.data documentation has wrong units for memory size Vince Weaver
@ 2019-07-27 17:15 ` Jiri Olsa
2019-07-29 21:35 ` [tip:perf/urgent] perf tools: Fix perf.data documentation " tip-bot for Vince Weaver
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Olsa @ 2019-07-27 17:15 UTC (permalink / raw)
To: Vince Weaver
Cc: linux-kernel, Arnaldo Carvalho de Melo, Peter Zijlstra,
Ingo Molnar, Alexander Shishkin, Namhyung Kim
On Thu, Jul 25, 2019 at 11:57:43AM -0400, Vince Weaver wrote:
>
> The perf.data-file-format documentation incorrectly says the
> HEADER_TOTAL_MEM results are in bytes. The results are in kilobytes
> (perf reads the value from /proc/meminfo)
>
> Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
> index 5f54feb19977..d030c87ed9f5 100644
> --- a/tools/perf/Documentation/perf.data-file-format.txt
> +++ b/tools/perf/Documentation/perf.data-file-format.txt
> @@ -126,7 +126,7 @@ vendor,family,model,stepping. For example: GenuineIntel,6,69,1
>
> HEADER_TOTAL_MEM = 10,
>
> -An uint64_t with the total memory in bytes.
> +An uint64_t with the total memory in kilobytes.
>
> HEADER_CMDLINE = 11,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/urgent] perf tools: Fix perf.data documentation units for memory size
2019-07-25 15:57 [patch] perf.data documentation has wrong units for memory size Vince Weaver
2019-07-27 17:15 ` Jiri Olsa
@ 2019-07-29 21:35 ` tip-bot for Vince Weaver
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Vince Weaver @ 2019-07-29 21:35 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, tglx, alexander.shishkin, mingo, jolsa, namhyung,
acme, hpa, vincent.weaver, peterz
Commit-ID: 2e9a06dda10aea81a17c623f08534dac6735434a
Gitweb: https://git.kernel.org/tip/2e9a06dda10aea81a17c623f08534dac6735434a
Author: Vince Weaver <vincent.weaver@maine.edu>
AuthorDate: Thu, 25 Jul 2019 11:57:43 -0400
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 29 Jul 2019 09:03:43 -0300
perf tools: Fix perf.data documentation units for memory size
The perf.data-file-format documentation incorrectly says the
HEADER_TOTAL_MEM results are in bytes. The results are in kilobytes
(perf reads the value from /proc/meminfo)
Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/alpine.DEB.2.21.1907251155500.22624@macbook-air
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Documentation/perf.data-file-format.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
index 5f54feb19977..d030c87ed9f5 100644
--- a/tools/perf/Documentation/perf.data-file-format.txt
+++ b/tools/perf/Documentation/perf.data-file-format.txt
@@ -126,7 +126,7 @@ vendor,family,model,stepping. For example: GenuineIntel,6,69,1
HEADER_TOTAL_MEM = 10,
-An uint64_t with the total memory in bytes.
+An uint64_t with the total memory in kilobytes.
HEADER_CMDLINE = 11,
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-29 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 15:57 [patch] perf.data documentation has wrong units for memory size Vince Weaver
2019-07-27 17:15 ` Jiri Olsa
2019-07-29 21:35 ` [tip:perf/urgent] perf tools: Fix perf.data documentation " tip-bot for Vince Weaver
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).