* [PATCH] sched: Fix the ifdef block in add_nr_running()
@ 2018-11-06 5:42 Viresh Kumar
2018-11-12 10:34 ` [tip:sched/core] sched/core: Clean up the #ifdef " tip-bot for Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Viresh Kumar @ 2018-11-06 5:42 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra
Cc: Viresh Kumar, Vincent Guittot, Daniel Lezcano, linux-kernel
There is no point in keeping the conditional statement of the if block
outside of the ifdef block, while all of its body is contained within
the ifdef block. Move the conditional statement as well under the ifdef
block.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
kernel/sched/sched.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index b7a3147874e3..e0e052a50fcd 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1801,12 +1801,12 @@ static inline void add_nr_running(struct rq *rq, unsigned count)
rq->nr_running = prev_nr + count;
- if (prev_nr < 2 && rq->nr_running >= 2) {
#ifdef CONFIG_SMP
+ if (prev_nr < 2 && rq->nr_running >= 2) {
if (!READ_ONCE(rq->rd->overload))
WRITE_ONCE(rq->rd->overload, 1);
-#endif
}
+#endif
sched_update_tick_dependency(rq);
}
--
2.19.1.568.g152ad8e3369a
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:sched/core] sched/core: Clean up the #ifdef block in add_nr_running()
2018-11-06 5:42 [PATCH] sched: Fix the ifdef block in add_nr_running() Viresh Kumar
@ 2018-11-12 10:34 ` tip-bot for Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Viresh Kumar @ 2018-11-12 10:34 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, linux-kernel, hpa, peterz, vincent.guittot, viresh.kumar,
torvalds, daniel.lezcano, mingo
Commit-ID: 3e184501083c38fa091f640acb13af17a21fd228
Gitweb: https://git.kernel.org/tip/3e184501083c38fa091f640acb13af17a21fd228
Author: Viresh Kumar <viresh.kumar@linaro.org>
AuthorDate: Tue, 6 Nov 2018 11:12:57 +0530
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 12 Nov 2018 11:18:06 +0100
sched/core: Clean up the #ifdef block in add_nr_running()
There is no point in keeping the conditional statement of the #if block
outside of the #ifdef block, while all of its body is contained within
the #ifdef block.
Move the conditional statement under the #ifdef block as well.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Link: http://lkml.kernel.org/r/78cbd78a615d6f9fdcd3327f1ead68470f92593e.1541482935.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/sched.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index b7a3147874e3..e0e052a50fcd 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1801,12 +1801,12 @@ static inline void add_nr_running(struct rq *rq, unsigned count)
rq->nr_running = prev_nr + count;
- if (prev_nr < 2 && rq->nr_running >= 2) {
#ifdef CONFIG_SMP
+ if (prev_nr < 2 && rq->nr_running >= 2) {
if (!READ_ONCE(rq->rd->overload))
WRITE_ONCE(rq->rd->overload, 1);
-#endif
}
+#endif
sched_update_tick_dependency(rq);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-12 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-06 5:42 [PATCH] sched: Fix the ifdef block in add_nr_running() Viresh Kumar
2018-11-12 10:34 ` [tip:sched/core] sched/core: Clean up the #ifdef " tip-bot for Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).