* [PATCH] genirq: annotate implicit fall through
@ 2019-01-14 20:31 Mathieu Malaterre
2019-01-15 9:45 ` [tip:irq/core] genirq: Annotate " tip-bot for Mathieu Malaterre
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Malaterre @ 2019-01-14 20:31 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Mathieu Malaterre, linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).
This commit remove the following warning:
kernel/irq/manage.c:725:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
kernel/irq/manage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index a4888ce4667a..1ca39dc4538d 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -723,6 +723,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned long flags)
case IRQ_SET_MASK_OK_DONE:
irqd_clear(&desc->irq_data, IRQD_TRIGGER_MASK);
irqd_set(&desc->irq_data, flags);
+ /* fall through */
case IRQ_SET_MASK_OK_NOCOPY:
flags = irqd_get_trigger_type(&desc->irq_data);
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:irq/core] genirq: Annotate implicit fall through
2019-01-14 20:31 [PATCH] genirq: annotate implicit fall through Mathieu Malaterre
@ 2019-01-15 9:45 ` tip-bot for Mathieu Malaterre
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Mathieu Malaterre @ 2019-01-15 9:45 UTC (permalink / raw)
To: linux-tip-commits; +Cc: hpa, malat, mingo, linux-kernel, tglx
Commit-ID: 44133f7eaebec227d1381868d642e3c64023520f
Gitweb: https://git.kernel.org/tip/44133f7eaebec227d1381868d642e3c64023520f
Author: Mathieu Malaterre <malat@debian.org>
AuthorDate: Mon, 14 Jan 2019 21:31:54 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 15 Jan 2019 10:40:34 +0100
genirq: Annotate implicit fall through
There is a plan to build the kernel with -Wimplicit-fallthrough. The
fallthrough in __irq_set_trigger() lacks an annotation. Add it.
Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190114203154.17125-1-malat@debian.org
---
kernel/irq/manage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index a4888ce4667a..1ca39dc4538d 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -723,6 +723,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned long flags)
case IRQ_SET_MASK_OK_DONE:
irqd_clear(&desc->irq_data, IRQD_TRIGGER_MASK);
irqd_set(&desc->irq_data, flags);
+ /* fall through */
case IRQ_SET_MASK_OK_NOCOPY:
flags = irqd_get_trigger_type(&desc->irq_data);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-15 9:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 20:31 [PATCH] genirq: annotate implicit fall through Mathieu Malaterre
2019-01-15 9:45 ` [tip:irq/core] genirq: Annotate " tip-bot for Mathieu Malaterre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).