* [tip:perf/core] perf tools: Just pr_debug() about not being able to read cacheline_size
@ 2016-07-16 20:44 tip-bot for Arnaldo Carvalho de Melo
0 siblings, 0 replies; only message in thread
From: tip-bot for Arnaldo Carvalho de Melo @ 2016-07-16 20:44 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, namhyung, cphlipot0, adrian.hunter, hpa, tglx,
linux-kernel, jolsa, wangnan0, mingo, dsahern
Commit-ID: 8811e8ea14c1056b09c794c67836b8a84584ddef
Gitweb: http://git.kernel.org/tip/8811e8ea14c1056b09c794c67836b8a84584ddef
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Fri, 15 Jul 2016 10:05:19 -0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 15 Jul 2016 10:08:29 -0300
perf tools: Just pr_debug() about not being able to read cacheline_size
So far the cacheline_size is only useful for the "dcacheline" --sort
order, i.e. if that is not used, which is the norm, then the user
shouldn't care that he is running this, say, on an Android system where
sysconf(_SC_LEVEL1_DCACHE_LINESIZE) and the
/sys/devices/system/cpu/cpu0/cache/index0/coherency_line_size sysfs file
isn't available.
An upcoming patch will emit an warning only for "--sort ...,dcacheline,...".
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Chris Phlipot <cphlipot0@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-580cnkvftunyvt9n7unsholi@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index 4b2ff02..64c0696 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -503,7 +503,7 @@ void pthread__unblock_sigwinch(void)
static void cache_line_size(int *cacheline_sizep)
{
if (sysfs__read_int("devices/system/cpu/cpu0/cache/index0/coherency_line_size", cacheline_sizep))
- perror("cannot determine cache line size");
+ pr_debug("cannot determine cache line size");
}
#endif
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-16 20:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-16 20:44 [tip:perf/core] perf tools: Just pr_debug() about not being able to read cacheline_size tip-bot for Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).