* [PATCH] gicv2m: Miscellaneous fixes for V2m resources and SPI ranges
@ 2015-12-23 0:24 Suravee Suthikulpanit
2015-12-29 11:03 ` [tip:irq/core] irqchip/gicv2m: Miscellaneous fixes for v2m " tip-bot for Suravee Suthikulpanit
0 siblings, 1 reply; 2+ messages in thread
From: Suravee Suthikulpanit @ 2015-12-23 0:24 UTC (permalink / raw)
To: marc.zyngier, tglx, jason, rjw, bhelgaas
Cc: Lorenzo Pieralisi, Will Deacon, Catalin Marinas, hanjun.guo,
tomasz.nowicki, graeme.gregory, dhdang, linux-arm-kernel,
linux-kernel, linux-acpi, Suravee Suthikulpanit
This patch contain fixes for v2m resources and SPI ranges:
* Fix off-by-one error when set up v2m resource end range in
gicv2m_acpi_init().
* Fix the off-by-one print error for SPI range.
* Use %pR to properly print resource range information.
Both ACPI and DT should now print:
GICv2m: range[mem 0xe1180000-0xe1180fff], SPI[64:319]
Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
---
Hi Marc,
Sorry for this minor last minute fixup. This should go on top
of the V7 of the GICv2m ACPI patch series. Although, this is
not urgent.
Thanks,
Suravee
drivers/irqchip/irq-gic-v2m.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index 7e2975d..5f346ea 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -365,9 +365,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode,
list_add_tail(&v2m->entry, &v2m_nodes);
- pr_info("range[%#lx:%#lx], SPI[%d:%d]\n",
- (unsigned long)res->start, (unsigned long)res->end,
- v2m->spi_start, (v2m->spi_start + v2m->nr_spis));
+ pr_info("range%pR, SPI[%d:%d]\n", res,
+ v2m->spi_start, (v2m->spi_start + v2m->nr_spis - 1));
return 0;
err_iounmap:
@@ -456,7 +455,8 @@ acpi_parse_madt_msi(struct acpi_subtable_header *header,
return -EINVAL;
res.start = m->base_address;
- res.end = m->base_address + SZ_4K;
+ res.end = m->base_address + SZ_4K - 1;
+ res.flags = IORESOURCE_MEM;
if (m->flags & ACPI_MADT_OVERRIDE_SPI_VALUES) {
spi_start = m->spi_base;
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:irq/core] irqchip/gicv2m: Miscellaneous fixes for v2m resources and SPI ranges
2015-12-23 0:24 [PATCH] gicv2m: Miscellaneous fixes for V2m resources and SPI ranges Suravee Suthikulpanit
@ 2015-12-29 11:03 ` tip-bot for Suravee Suthikulpanit
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Suravee Suthikulpanit @ 2015-12-29 11:03 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, jason, Catalin.Marinas, bhelgaas, dhdang, tglx,
linux-kernel, lorenzo.pieralisi, Suravee.Suthikulpanit,
tomasz.nowicki, rjw, graeme.gregory, marc.zyngier, will.deacon,
linux-arm-kernel, hanjun.guo, hpa
Commit-ID: 5a1ff480f4ec40ace313c16b0543c7c6af09e227
Gitweb: http://git.kernel.org/tip/5a1ff480f4ec40ace313c16b0543c7c6af09e227
Author: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
AuthorDate: Tue, 22 Dec 2015 16:24:23 -0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 29 Dec 2015 11:58:53 +0100
irqchip/gicv2m: Miscellaneous fixes for v2m resources and SPI ranges
This patch contain fixes for v2m resources and SPI ranges:
* Fix off-by-one error when set up v2m resource end range in
gicv2m_acpi_init().
* Fix the off-by-one print error for SPI range.
* Use %pR to properly print resource range information.
Both ACPI and DT should now print:
GICv2m: range[mem 0xe1180000-0xe1180fff], SPI[64:319]
Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>
Cc: <hanjun.guo@linaro.org>
Cc: <tomasz.nowicki@linaro.org>
Cc: <graeme.gregory@linaro.org>
Cc: <dhdang@apm.com>
Cc: <linux-arm-kernel@lists.infradead.org>
Cc: <marc.zyngier@arm.com>
Cc: <jason@lakedaemon.net>
Cc: <rjw@rjwysocki.net>
Link: http://lkml.kernel.org/r/1450830263-28914-1-git-send-email-Suravee.Suthikulpanit@amd.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-gic-v2m.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index e2d2d02..c779f83 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -365,9 +365,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode,
list_add_tail(&v2m->entry, &v2m_nodes);
- pr_info("range[%#lx:%#lx], SPI[%d:%d]\n",
- (unsigned long)res->start, (unsigned long)res->end,
- v2m->spi_start, (v2m->spi_start + v2m->nr_spis));
+ pr_info("range%pR, SPI[%d:%d]\n", res,
+ v2m->spi_start, (v2m->spi_start + v2m->nr_spis - 1));
return 0;
err_iounmap:
@@ -456,7 +455,8 @@ acpi_parse_madt_msi(struct acpi_subtable_header *header,
return -EINVAL;
res.start = m->base_address;
- res.end = m->base_address + SZ_4K;
+ res.end = m->base_address + SZ_4K - 1;
+ res.flags = IORESOURCE_MEM;
if (m->flags & ACPI_MADT_OVERRIDE_SPI_VALUES) {
spi_start = m->spi_base;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-29 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-23 0:24 [PATCH] gicv2m: Miscellaneous fixes for V2m resources and SPI ranges Suravee Suthikulpanit
2015-12-29 11:03 ` [tip:irq/core] irqchip/gicv2m: Miscellaneous fixes for v2m " tip-bot for Suravee Suthikulpanit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).