[PATCH 1/2] clocksource: mips-gic-timer: Print an error if IRQ setup fails

* [PATCH 1/2] clocksource: mips-gic-timer: Print an error if IRQ setup fails
@ 2016-09-13 16:56 Paul Burton
  2016-09-13 16:56 ` [PATCH 2/2] clocksource: mips-gic-timer: Stop checking cpu_has_counter Paul Burton
  2016-09-20 21:30 ` [tip:timers/core] clocksource/mips-gic-timer: Print an error if IRQ setup fails tip-bot for Paul Burton
  0 siblings, 2 replies; 4+ messages in thread
From: Paul Burton @ 2016-09-13 16:56 UTC (permalink / raw)
  To: linux-mips; +Cc: Paul Burton, Daniel Lezcano, Thomas Gleixner, linux-kernel

We've checked for errors from setup_irq_percpu since commit f95ac8558b88
("CLOCKSOURCE: mips-gic: Add missing error returns checks") but didn't
print an error message in the failure case. This makes it very easy to
overlook the GIC timer clock event driver not being registered, since
we'll generally just use a different clock event driver if that happens.

Print an error if IRQ setup fails in order to make such problems harder
to miss (ie. not completely silent).

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org
---
 drivers/clocksource/mips-gic-timer.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c
index b4b3ab5..802055b 100644
--- a/drivers/clocksource/mips-gic-timer.c
+++ b/drivers/clocksource/mips-gic-timer.c
@@ -113,8 +113,11 @@ static int gic_clockevent_init(void)
 		return -ENXIO;
 
 	ret = setup_percpu_irq(gic_timer_irq, &gic_compare_irqaction);
-	if (ret < 0)
+	if (ret < 0) {
+		pr_err("GIC timer IRQ %d setup failed: %d\n",
+		       gic_timer_irq, ret);
 		return ret;
+	}
 
 	cpuhp_setup_state(CPUHP_AP_MIPS_GIC_TIMER_STARTING,
 			  "AP_MIPS_GIC_TIMER_STARTING", gic_starting_cpu,
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread