* [PATCH] perf tools: Allow to specify lib compile variable for spec usage
@ 2014-08-25 14:55 Jiri Olsa
2014-08-26 13:26 ` Kyle McMartin
2014-09-19 5:20 ` [tip:perf/core] " tip-bot for Jiri Olsa
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Olsa @ 2014-08-25 14:55 UTC (permalink / raw)
To: linux-kernel
Cc: Jiri Olsa, Kyle McMartin, Arnaldo Carvalho de Melo,
Corey Ashford, David Ahern, Frederic Weisbecker, Ingo Molnar,
Namhyung Kim, Paul Mackerras, Peter Zijlstra
We need a way to specify $(lib) part of the installation
path for traceevent plugin libraries. Currently we use
'lib64' for x86_64 and 'lib' otherwise.
Instead of listing all possible values, this change allows
the rpm spec code to specify the correct $(lib) part based
on processed architecture, like
$ make ... lib=%{_lib}
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/config/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 75d4c237b03d..eaf36dafb482 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -651,11 +651,13 @@ else
sysconfdir = $(prefix)/etc
ETC_PERFCONFIG = etc/perfconfig
endif
+ifndef lib
ifeq ($(IS_X86_64),1)
lib = lib64
else
lib = lib
endif
+endif # lib
libdir = $(prefix)/$(lib)
# Shell quote (do not use $(call) to accommodate ancient setups);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf tools: Allow to specify lib compile variable for spec usage
2014-08-25 14:55 [PATCH] perf tools: Allow to specify lib compile variable for spec usage Jiri Olsa
@ 2014-08-26 13:26 ` Kyle McMartin
2014-09-19 5:20 ` [tip:perf/core] " tip-bot for Jiri Olsa
1 sibling, 0 replies; 3+ messages in thread
From: Kyle McMartin @ 2014-08-26 13:26 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Kyle McMartin, Arnaldo Carvalho de Melo,
Corey Ashford, David Ahern, Frederic Weisbecker, Ingo Molnar,
Namhyung Kim, Paul Mackerras, Peter Zijlstra
On Mon, Aug 25, 2014 at 10:55 AM, Jiri Olsa <jolsa@kernel.org> wrote:
> We need a way to specify $(lib) part of the installation
> path for traceevent plugin libraries. Currently we use
> 'lib64' for x86_64 and 'lib' otherwise.
>
> Instead of listing all possible values, this change allows
> the rpm spec code to specify the correct $(lib) part based
> on processed architecture, like
>
> $ make ... lib=%{_lib}
>
> Cc: Kyle McMartin <kyle@mcmartin.ca>
I had made a similar change to Fedora, which I replaced with this, and
it worked fine.
LGTM :)
Tested-by: Kyle McMartin <kyle@mcmartin.ca>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/config/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 75d4c237b03d..eaf36dafb482 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -651,11 +651,13 @@ else
> sysconfdir = $(prefix)/etc
> ETC_PERFCONFIG = etc/perfconfig
> endif
> +ifndef lib
> ifeq ($(IS_X86_64),1)
> lib = lib64
> else
> lib = lib
> endif
> +endif # lib
> libdir = $(prefix)/$(lib)
>
> # Shell quote (do not use $(call) to accommodate ancient setups);
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/core] perf tools: Allow to specify lib compile variable for spec usage
2014-08-25 14:55 [PATCH] perf tools: Allow to specify lib compile variable for spec usage Jiri Olsa
2014-08-26 13:26 ` Kyle McMartin
@ 2014-09-19 5:20 ` tip-bot for Jiri Olsa
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Jiri Olsa @ 2014-09-19 5:20 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, paulus, hpa, mingo, jolsa, a.p.zijlstra,
namhyung, kyle, fweisbec, dsahern, tglx, cjashfor
Commit-ID: 6997af72e6c1e9d8c1cc511dc9485e9ee69a5e20
Gitweb: http://git.kernel.org/tip/6997af72e6c1e9d8c1cc511dc9485e9ee69a5e20
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Mon, 25 Aug 2014 16:55:52 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 17 Sep 2014 17:08:08 -0300
perf tools: Allow to specify lib compile variable for spec usage
We need a way to specify $(lib) part of the installation path for
traceevent plugin libraries. Currently we use 'lib64' for x86_64 and
'lib' otherwise.
Instead of listing all possible values, this change allows the rpm spec
code to specify the correct $(lib) part based on processed architecture,
like
$ make ... lib=%{_lib}
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Kyle McMartin <kyle@mcmartin.ca>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1408978552-17131-1-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/config/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 98c9fd1..58f6091 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -653,11 +653,13 @@ else
sysconfdir = $(prefix)/etc
ETC_PERFCONFIG = etc/perfconfig
endif
+ifndef lib
ifeq ($(IS_X86_64),1)
lib = lib64
else
lib = lib
endif
+endif # lib
libdir = $(prefix)/$(lib)
# Shell quote (do not use $(call) to accommodate ancient setups);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-19 5:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-25 14:55 [PATCH] perf tools: Allow to specify lib compile variable for spec usage Jiri Olsa
2014-08-26 13:26 ` Kyle McMartin
2014-09-19 5:20 ` [tip:perf/core] " tip-bot for Jiri Olsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).