linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/vdso: Add ARCH_MAP_VDSO_X32 if CONFIG_X86_X32_ABI.
@ 2016-09-17  0:51 Vinson Lee
  2016-09-19 11:33 ` Dmitry Safonov
  2016-09-19 22:06 ` [tip:x86/vdso] x86/vdso: Use CONFIG_X86_X32_ABI to enable vdso prctl tip-bot for Vinson Lee
  0 siblings, 2 replies; 3+ messages in thread
From: Vinson Lee @ 2016-09-17  0:51 UTC (permalink / raw)
  To: Dmitry Safonov, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	x86, Andy Lutomirski, Borislav Petkov, Dmitry Vyukov,
	Brian Gerst
  Cc: linux-kernel

vdso_image_x32 is generated if CONFIG_X86_X32_ABI.

This patch fixes this build error on CentOS 6.8 with gcc 4.4.

  LD      init/built-in.o
arch/x86/built-in.o: In function `do_arch_prctl':
(.text+0x27466): undefined reference to `vdso_image_x32'
arch/x86/built-in.o: In function `do_arch_prctl':
(.text+0x27477): undefined reference to `vdso_image_x32'

Fixes: 2eefd8789698 ("x86/arch_prctl/vdso: Add ARCH_MAP_VDSO_*")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
---
 arch/x86/kernel/process_64.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index b34caea..b3760b3 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -592,7 +592,7 @@ long do_arch_prctl(struct task_struct *task, int code, unsigned long addr)
 	}
 
 #ifdef CONFIG_CHECKPOINT_RESTORE
-# ifdef CONFIG_X86_X32
+# ifdef CONFIG_X86_X32_ABI
 	case ARCH_MAP_VDSO_X32:
 		return prctl_map_vdso(&vdso_image_x32, addr);
 # endif
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] x86/vdso: Add ARCH_MAP_VDSO_X32 if CONFIG_X86_X32_ABI.
  2016-09-17  0:51 [PATCH] x86/vdso: Add ARCH_MAP_VDSO_X32 if CONFIG_X86_X32_ABI Vinson Lee
@ 2016-09-19 11:33 ` Dmitry Safonov
  2016-09-19 22:06 ` [tip:x86/vdso] x86/vdso: Use CONFIG_X86_X32_ABI to enable vdso prctl tip-bot for Vinson Lee
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Safonov @ 2016-09-19 11:33 UTC (permalink / raw)
  To: Vinson Lee, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
	Andy Lutomirski, Borislav Petkov, Dmitry Vyukov, Brian Gerst
  Cc: linux-kernel

On 09/17/2016 03:51 AM, Vinson Lee wrote:
> vdso_image_x32 is generated if CONFIG_X86_X32_ABI.
>
> This patch fixes this build error on CentOS 6.8 with gcc 4.4.
>
>   LD      init/built-in.o
> arch/x86/built-in.o: In function `do_arch_prctl':
> (.text+0x27466): undefined reference to `vdso_image_x32'
> arch/x86/built-in.o: In function `do_arch_prctl':
> (.text+0x27477): undefined reference to `vdso_image_x32'
>
> Fixes: 2eefd8789698 ("x86/arch_prctl/vdso: Add ARCH_MAP_VDSO_*")
> Signed-off-by: Vinson Lee <vlee@freedesktop.org>

Thanks!
Reviewed-by: Dmitry Safonov <dsafonov@virtuozzo.com>

Ifdeffery in arch/x86/include/asm/vdso.h dazzled my eyes.

-- 
              Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [tip:x86/vdso] x86/vdso: Use CONFIG_X86_X32_ABI to enable vdso prctl
  2016-09-17  0:51 [PATCH] x86/vdso: Add ARCH_MAP_VDSO_X32 if CONFIG_X86_X32_ABI Vinson Lee
  2016-09-19 11:33 ` Dmitry Safonov
@ 2016-09-19 22:06 ` tip-bot for Vinson Lee
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Vinson Lee @ 2016-09-19 22:06 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: dvyukov, linux-kernel, vlee, luto, tglx, dsafonov, mingo, hpa,
	brgerst, bp

Commit-ID:  6e68b08728ce3365c713f8663c6b05a79e2bbca1
Gitweb:     http://git.kernel.org/tip/6e68b08728ce3365c713f8663c6b05a79e2bbca1
Author:     Vinson Lee <vlee@freedesktop.org>
AuthorDate: Sat, 17 Sep 2016 00:51:53 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 20 Sep 2016 00:01:48 +0200

x86/vdso: Use CONFIG_X86_X32_ABI to enable vdso prctl

The prctl code which references vdso_image_x32 is built when CONFIG_X86_X32
is set. This results in the following build failure:

  LD      init/built-in.o
arch/x86/built-in.o: In function `do_arch_prctl':
(.text+0x27466): undefined reference to `vdso_image_x32'

vdso_image_x32 depends on CONFIG_X86_X32_ABI. So we need to make the prctl
depend on that as well.

[ tglx: Massaged changelog ]

Fixes: 2eefd8789698 ("x86/arch_prctl/vdso: Add ARCH_MAP_VDSO_*")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Dmitry Vyukov <dvyukov@google.com>
Link: http://lkml.kernel.org/r/1474073513-6656-1-git-send-email-vlee@freedesktop.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/kernel/process_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index b26a009..b4603b7 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -592,7 +592,7 @@ long do_arch_prctl(struct task_struct *task, int code, unsigned long addr)
 	}
 
 #ifdef CONFIG_CHECKPOINT_RESTORE
-# ifdef CONFIG_X86_X32
+# ifdef CONFIG_X86_X32_ABI
 	case ARCH_MAP_VDSO_X32:
 		return prctl_map_vdso(&vdso_image_x32, addr);
 # endif

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-19 22:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-17  0:51 [PATCH] x86/vdso: Add ARCH_MAP_VDSO_X32 if CONFIG_X86_X32_ABI Vinson Lee
2016-09-19 11:33 ` Dmitry Safonov
2016-09-19 22:06 ` [tip:x86/vdso] x86/vdso: Use CONFIG_X86_X32_ABI to enable vdso prctl tip-bot for Vinson Lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).