* [PATCH] x86/boot/string: Add missing strchr declaration
@ 2017-06-23 14:36 Tommy Nguyen
2017-06-24 7:18 ` [tip:x86/cleanups] x86/boot: Add missing strchr() declaration tip-bot for Tommy Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Tommy Nguyen @ 2017-06-23 14:36 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Thomas Gleixner, Ingo Molnar, x86, linux-kernel
The Sparse static analyzer emits this warning:
symbol 'strchr' was not declared. Should it be static?
This patch adds the appropriate extern declaration to string.h
to fix the warning.
Signed-off-by: Tommy Nguyen <remyabel@gmail.com>
---
arch/x86/boot/string.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
index 113588d..fa03b8f 100644
--- a/arch/x86/boot/string.h
+++ b/arch/x86/boot/string.h
@@ -22,6 +22,7 @@ extern int strcmp(const char *str1, const char *str2);
extern int strncmp(const char *cs, const char *ct, size_t count);
extern size_t strlen(const char *s);
extern char *strstr(const char *s1, const char *s2);
+extern char *strchr(const char *s, int c);
extern size_t strnlen(const char *s, size_t maxlen);
extern unsigned int atou(const char *s);
extern unsigned long long simple_strtoull(const char *cp, char **endp,
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/cleanups] x86/boot: Add missing strchr() declaration
2017-06-23 14:36 [PATCH] x86/boot/string: Add missing strchr declaration Tommy Nguyen
@ 2017-06-24 7:18 ` tip-bot for Tommy Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Tommy Nguyen @ 2017-06-24 7:18 UTC (permalink / raw)
To: linux-tip-commits
Cc: remyabel, mingo, peterz, hpa, tglx, linux-kernel, torvalds
Commit-ID: 6ec829a9d1c8562ac15c50402e5de550bb28161e
Gitweb: http://git.kernel.org/tip/6ec829a9d1c8562ac15c50402e5de550bb28161e
Author: Tommy Nguyen <remyabel@gmail.com>
AuthorDate: Fri, 23 Jun 2017 10:36:01 -0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 24 Jun 2017 08:53:33 +0200
x86/boot: Add missing strchr() declaration
The Sparse static analyzer emits this warning:
symbol 'strchr' was not declared. Should it be static?
This patch adds the appropriate extern declaration to string.h
to fix the warning.
Signed-off-by: Tommy Nguyen <remyabel@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170623143601.GA20743@NoChina
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/boot/string.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
index 113588d..f274a50 100644
--- a/arch/x86/boot/string.h
+++ b/arch/x86/boot/string.h
@@ -22,6 +22,7 @@ extern int strcmp(const char *str1, const char *str2);
extern int strncmp(const char *cs, const char *ct, size_t count);
extern size_t strlen(const char *s);
extern char *strstr(const char *s1, const char *s2);
+extern char *strchr(const char *s, int c);
extern size_t strnlen(const char *s, size_t maxlen);
extern unsigned int atou(const char *s);
extern unsigned long long simple_strtoull(const char *cp, char **endp,
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-24 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 14:36 [PATCH] x86/boot/string: Add missing strchr declaration Tommy Nguyen
2017-06-24 7:18 ` [tip:x86/cleanups] x86/boot: Add missing strchr() declaration tip-bot for Tommy Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).