* [PATCH] perf/x86/uncore: fix SNB-EP/IVT Cbox filter mappings
@ 2014-06-30 14:46 Stephane Eranian
2014-07-10 19:16 ` Stephane Eranian
2014-07-16 19:19 ` [tip:perf/urgent] perf/x86/intel/uncore: Fix SNB-EP/ IVT " tip-bot for Stephane Eranian
0 siblings, 2 replies; 5+ messages in thread
From: Stephane Eranian @ 2014-06-30 14:46 UTC (permalink / raw)
To: linux-kernel; +Cc: peterz, mingo, ak, zheng.z.yan
This patch fixes the SNB-EP and IVT Cbox filter mapping
table. The table controls which filters are supported by
which events. There were several mistakes in those tables
causing some filters to be ignored, such as NID on
TOR_INSERTS.
Signed-off-by: Stephane Eranian <eranian@google.com>
---
arch/x86/kernel/cpu/perf_event_intel_uncore.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
index 65bbbea..ae6552a 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -550,16 +550,16 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
- SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xc),
- SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xc),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xa),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xa),
SNBEP_CBO_EVENT_EXTRA_REG(0x4435, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x4835, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x4a35, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x5035, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x8),
SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x8),
- SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xc),
- SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xc),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xa),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xa),
SNBEP_CBO_EVENT_EXTRA_REG(0x4436, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x4836, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x4a36, 0xffff, 0x2),
@@ -1222,6 +1222,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
+
SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
@@ -1245,7 +1246,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
SNBEP_CBO_EVENT_EXTRA_REG(0x8335, 0xffff, 0x10),
SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x10),
SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x10),
- SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x2136, 0xffff, 0x10),
SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10),
SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0x18),
SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0x18),
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] perf/x86/uncore: fix SNB-EP/IVT Cbox filter mappings
2014-06-30 14:46 [PATCH] perf/x86/uncore: fix SNB-EP/IVT Cbox filter mappings Stephane Eranian
@ 2014-07-10 19:16 ` Stephane Eranian
2014-07-11 5:37 ` Yan, Zheng
2014-07-11 8:23 ` Peter Zijlstra
2014-07-16 19:19 ` [tip:perf/urgent] perf/x86/intel/uncore: Fix SNB-EP/ IVT " tip-bot for Stephane Eranian
1 sibling, 2 replies; 5+ messages in thread
From: Stephane Eranian @ 2014-07-10 19:16 UTC (permalink / raw)
To: LKML; +Cc: Peter Zijlstra, mingo, ak, Yan, Zheng
On Mon, Jun 30, 2014 at 4:46 PM, Stephane Eranian <eranian@google.com> wrote:
>
> This patch fixes the SNB-EP and IVT Cbox filter mapping
> table. The table controls which filters are supported by
> which events. There were several mistakes in those tables
> causing some filters to be ignored, such as NID on
> TOR_INSERTS.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Any comment on this patch?
> ---
> arch/x86/kernel/cpu/perf_event_intel_uncore.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> index 65bbbea..ae6552a 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -550,16 +550,16 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
> SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
> - SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xc),
> - SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xc),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xa),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xa),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4435, 0xffff, 0x2),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4835, 0xffff, 0x2),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4a35, 0xffff, 0x2),
> SNBEP_CBO_EVENT_EXTRA_REG(0x5035, 0xffff, 0x2),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x8),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x8),
> - SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xc),
> - SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xc),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xa),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xa),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4436, 0xffff, 0x2),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4836, 0xffff, 0x2),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4a36, 0xffff, 0x2),
> @@ -1222,6 +1222,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
> SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
> SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
> SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
> +
> SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
> SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
> @@ -1245,7 +1246,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
> SNBEP_CBO_EVENT_EXTRA_REG(0x8335, 0xffff, 0x10),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x10),
> SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x10),
> - SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10),
> + SNBEP_CBO_EVENT_EXTRA_REG(0x2136, 0xffff, 0x10),
> SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0x18),
> SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0x18),
> --
> 1.8.3.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf/x86/uncore: fix SNB-EP/IVT Cbox filter mappings
2014-07-10 19:16 ` Stephane Eranian
@ 2014-07-11 5:37 ` Yan, Zheng
2014-07-11 8:23 ` Peter Zijlstra
1 sibling, 0 replies; 5+ messages in thread
From: Yan, Zheng @ 2014-07-11 5:37 UTC (permalink / raw)
To: Stephane Eranian, LKML; +Cc: Peter Zijlstra, mingo, ak
On 07/11/2014 03:16 AM, Stephane Eranian wrote:
> On Mon, Jun 30, 2014 at 4:46 PM, Stephane Eranian <eranian@google.com> wrote:
>>
>> This patch fixes the SNB-EP and IVT Cbox filter mapping
>> table. The table controls which filters are supported by
>> which events. There were several mistakes in those tables
>> causing some filters to be ignored, such as NID on
>> TOR_INSERTS.
>>
>> Signed-off-by: Stephane Eranian <eranian@google.com>
>
> Any comment on this patch?
sorry for the delay
Reviewed-by: Yan, Zheng <zheng.z.yan@intel.com>
>
>> ---
>> arch/x86/kernel/cpu/perf_event_intel_uncore.c | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
>> index 65bbbea..ae6552a 100644
>> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
>> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
>> @@ -550,16 +550,16 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
>> - SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xc),
>> - SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xc),
>> + SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xa),
>> + SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xa),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4435, 0xffff, 0x2),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4835, 0xffff, 0x2),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4a35, 0xffff, 0x2),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x5035, 0xffff, 0x2),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x8),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x8),
>> - SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xc),
>> - SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xc),
>> + SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xa),
>> + SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xa),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4436, 0xffff, 0x2),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4836, 0xffff, 0x2),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4a36, 0xffff, 0x2),
>> @@ -1222,6 +1222,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
>> SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
>> SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
>> +
>> SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
>> @@ -1245,7 +1246,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
>> SNBEP_CBO_EVENT_EXTRA_REG(0x8335, 0xffff, 0x10),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x10),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x10),
>> - SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10),
>> + SNBEP_CBO_EVENT_EXTRA_REG(0x2136, 0xffff, 0x10),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0x18),
>> SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0x18),
>> --
>> 1.8.3.2
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf/x86/uncore: fix SNB-EP/IVT Cbox filter mappings
2014-07-10 19:16 ` Stephane Eranian
2014-07-11 5:37 ` Yan, Zheng
@ 2014-07-11 8:23 ` Peter Zijlstra
1 sibling, 0 replies; 5+ messages in thread
From: Peter Zijlstra @ 2014-07-11 8:23 UTC (permalink / raw)
To: Stephane Eranian; +Cc: LKML, mingo, ak, Yan, Zheng
On Thu, Jul 10, 2014 at 09:16:30PM +0200, Stephane Eranian wrote:
> On Mon, Jun 30, 2014 at 4:46 PM, Stephane Eranian <eranian@google.com> wrote:
> >
> > This patch fixes the SNB-EP and IVT Cbox filter mapping
> > table. The table controls which filters are supported by
> > which events. There were several mistakes in those tables
> > causing some filters to be ignored, such as NID on
> > TOR_INSERTS.
> >
> > Signed-off-by: Stephane Eranian <eranian@google.com>
>
> Any comment on this patch?
I queued, it. I'll try and get it into tip over the weekend or so.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/urgent] perf/x86/intel/uncore: Fix SNB-EP/ IVT Cbox filter mappings
2014-06-30 14:46 [PATCH] perf/x86/uncore: fix SNB-EP/IVT Cbox filter mappings Stephane Eranian
2014-07-10 19:16 ` Stephane Eranian
@ 2014-07-16 19:19 ` tip-bot for Stephane Eranian
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Stephane Eranian @ 2014-07-16 19:19 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, eranian, hpa, mingo, torvalds, peterz, acme, tglx
Commit-ID: 7711fe4fc2606712125cff1a55ce00df2ae0f1fb
Gitweb: http://git.kernel.org/tip/7711fe4fc2606712125cff1a55ce00df2ae0f1fb
Author: Stephane Eranian <eranian@google.com>
AuthorDate: Mon, 30 Jun 2014 16:46:24 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 16 Jul 2014 13:18:41 +0200
perf/x86/intel/uncore: Fix SNB-EP/IVT Cbox filter mappings
This patch fixes the SNB-EP and IVT Cbox filter mapping
table. The table controls which filters are supported by
which events. There were several mistakes in those tables
causing some filters to be ignored, such as NID on
TOR_INSERTS.
Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: zheng.z.yan@intel.com
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140630144624.GA2604@quad
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/perf_event_intel_uncore.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
index 65bbbea..ae6552a 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -550,16 +550,16 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
- SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xc),
- SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xc),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xa),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xa),
SNBEP_CBO_EVENT_EXTRA_REG(0x4435, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x4835, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x4a35, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x5035, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x8),
SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x8),
- SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xc),
- SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xc),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xa),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xa),
SNBEP_CBO_EVENT_EXTRA_REG(0x4436, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x4836, 0xffff, 0x2),
SNBEP_CBO_EVENT_EXTRA_REG(0x4a36, 0xffff, 0x2),
@@ -1222,6 +1222,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
+
SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
@@ -1245,7 +1246,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
SNBEP_CBO_EVENT_EXTRA_REG(0x8335, 0xffff, 0x10),
SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x10),
SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x10),
- SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10),
+ SNBEP_CBO_EVENT_EXTRA_REG(0x2136, 0xffff, 0x10),
SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10),
SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0x18),
SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0x18),
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-16 19:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-30 14:46 [PATCH] perf/x86/uncore: fix SNB-EP/IVT Cbox filter mappings Stephane Eranian
2014-07-10 19:16 ` Stephane Eranian
2014-07-11 5:37 ` Yan, Zheng
2014-07-11 8:23 ` Peter Zijlstra
2014-07-16 19:19 ` [tip:perf/urgent] perf/x86/intel/uncore: Fix SNB-EP/ IVT " tip-bot for Stephane Eranian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).