* [patch 6/8] x86/platform/uv: Use apic_ack_irq()
@ 2018-06-04 15:33 Thomas Gleixner
2018-06-05 7:13 ` Song Liu
2018-06-06 13:33 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Gleixner @ 2018-06-04 15:33 UTC (permalink / raw)
To: LKML
Cc: Ingo Molnar, Peter Zijlstra, Borislav Petkov, Dmitry Safonov,
Tariq Toukan, Song Liu, Joerg Roedel, Mike Travis, stable
[-- Attachment #1: x86-platform-uv--Use-apic_ack_irq.patch --]
[-- Type: text/plain, Size: 1180 bytes --]
To address the EBUSY fail of interrupt affinity settings in case that the
previous setting has not been cleaned up yet, use the new apic_ack_irq()
function instead of the special uv_ack_apic() implementation which is
merily a wrapper around ack_APIC_irq().
Preparatory change for the real fix
Fixes: dccfe3147b42 ("x86/vector: Simplify vector move cleanup")
Reported-by: Song Liu <liu.song.a23@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
---
arch/x86/platform/uv/uv_irq.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
--- a/arch/x86/platform/uv/uv_irq.c
+++ b/arch/x86/platform/uv/uv_irq.c
@@ -47,11 +47,6 @@ static void uv_program_mmr(struct irq_cf
static void uv_noop(struct irq_data *data) { }
-static void uv_ack_apic(struct irq_data *data)
-{
- ack_APIC_irq();
-}
-
static int
uv_set_irq_affinity(struct irq_data *data, const struct cpumask *mask,
bool force)
@@ -73,7 +68,7 @@ static struct irq_chip uv_irq_chip = {
.name = "UV-CORE",
.irq_mask = uv_noop,
.irq_unmask = uv_noop,
- .irq_eoi = uv_ack_apic,
+ .irq_eoi = apic_ack_irq,
.irq_set_affinity = uv_set_irq_affinity,
};
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 6/8] x86/platform/uv: Use apic_ack_irq()
2018-06-04 15:33 [patch 6/8] x86/platform/uv: Use apic_ack_irq() Thomas Gleixner
@ 2018-06-05 7:13 ` Song Liu
2018-06-06 13:33 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Song Liu @ 2018-06-05 7:13 UTC (permalink / raw)
To: Thomas Gleixner
Cc: LKML, Ingo Molnar, Peter Zijlstra, Borislav Petkov,
Dmitry Safonov, Tariq Toukan, Joerg Roedel, Mike Travis, stable
Tested-by: Song Liu <songliubraving@fb.com>
On Mon, Jun 4, 2018 at 8:33 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/urgent] x86/platform/uv: Use apic_ack_irq()
2018-06-04 15:33 [patch 6/8] x86/platform/uv: Use apic_ack_irq() Thomas Gleixner
2018-06-05 7:13 ` Song Liu
@ 2018-06-06 13:33 ` tip-bot for Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Thomas Gleixner @ 2018-06-06 13:33 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, tglx, jroedel, hpa, mike.travis, bp, 0x7f454c46, mingo,
songliubraving, tariqt, liu.song.a23, linux-kernel
Commit-ID: 839b0f1c4ef674cd929a42304c078afca278581a
Gitweb: https://git.kernel.org/tip/839b0f1c4ef674cd929a42304c078afca278581a
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Mon, 4 Jun 2018 17:33:58 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 6 Jun 2018 15:18:21 +0200
x86/platform/uv: Use apic_ack_irq()
To address the EBUSY fail of interrupt affinity settings in case that the
previous setting has not been cleaned up yet, use the new apic_ack_irq()
function instead of the special uv_ack_apic() implementation which is
merily a wrapper around ack_APIC_irq().
Preparatory change for the real fix
Fixes: dccfe3147b42 ("x86/vector: Simplify vector move cleanup")
Reported-by: Song Liu <liu.song.a23@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Song Liu <songliubraving@fb.com>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Dmitry Safonov <0x7f454c46@gmail.com>
Cc: stable@vger.kernel.org
Cc: Mike Travis <mike.travis@hpe.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Tariq Toukan <tariqt@mellanox.com>
Link: https://lkml.kernel.org/r/20180604162224.721691398@linutronix.de
---
arch/x86/platform/uv/uv_irq.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/x86/platform/uv/uv_irq.c b/arch/x86/platform/uv/uv_irq.c
index e4cb9f4cde8a..fc13cbbb2dce 100644
--- a/arch/x86/platform/uv/uv_irq.c
+++ b/arch/x86/platform/uv/uv_irq.c
@@ -47,11 +47,6 @@ static void uv_program_mmr(struct irq_cfg *cfg, struct uv_irq_2_mmr_pnode *info)
static void uv_noop(struct irq_data *data) { }
-static void uv_ack_apic(struct irq_data *data)
-{
- ack_APIC_irq();
-}
-
static int
uv_set_irq_affinity(struct irq_data *data, const struct cpumask *mask,
bool force)
@@ -73,7 +68,7 @@ static struct irq_chip uv_irq_chip = {
.name = "UV-CORE",
.irq_mask = uv_noop,
.irq_unmask = uv_noop,
- .irq_eoi = uv_ack_apic,
+ .irq_eoi = apic_ack_irq,
.irq_set_affinity = uv_set_irq_affinity,
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-06 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-04 15:33 [patch 6/8] x86/platform/uv: Use apic_ack_irq() Thomas Gleixner
2018-06-05 7:13 ` Song Liu
2018-06-06 13:33 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).