* [PATCH] tracing: don't select FRAME_POINTER on PPC
@ 2012-02-27 8:08 Gerlando Falauto
2012-02-27 13:37 ` Steven Rostedt
2012-03-22 21:17 ` [tip:perf/urgent] tracing: Do not " tip-bot for Gerlando Falauto
0 siblings, 2 replies; 3+ messages in thread
From: Gerlando Falauto @ 2012-02-27 8:08 UTC (permalink / raw)
To: holger.brunck
Cc: Gerlando Falauto, Steven Rostedt, Frederic Weisbecker,
Ingo Molnar, linux-kernel, ---,
1.7.1
On PowerPC, FUNCTION_TRACER selects FRAME_POINTER, even
though the architecture does not support it.
This causes the following warning:
warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && FUNCTION_TRACER && KMEMCHECK) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300) || ARCH_WANT_FRAME_POINTERS)
So remove the warning by adding the extra condition
"if !PPC" to FUNCTION_TRACER for FRAME_POINTER selection
Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
---
kernel/trace/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 2ad39e5..fbdec2e 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -141,7 +141,7 @@ if FTRACE
config FUNCTION_TRACER
bool "Kernel Function Tracer"
depends on HAVE_FUNCTION_TRACER
- select FRAME_POINTER if !ARM_UNWIND && !S390 && !MICROBLAZE
+ select FRAME_POINTER if !ARM_UNWIND && !PPC && !S390 && !MICROBLAZE
select KALLSYMS
select GENERIC_TRACER
select CONTEXT_SWITCH_TRACER
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: don't select FRAME_POINTER on PPC
2012-02-27 8:08 [PATCH] tracing: don't select FRAME_POINTER on PPC Gerlando Falauto
@ 2012-02-27 13:37 ` Steven Rostedt
2012-03-22 21:17 ` [tip:perf/urgent] tracing: Do not " tip-bot for Gerlando Falauto
1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2012-02-27 13:37 UTC (permalink / raw)
To: Gerlando Falauto
Cc: holger.brunck, Frederic Weisbecker, Ingo Molnar, linux-kernel
On Mon, 2012-02-27 at 09:08 +0100, Gerlando Falauto wrote:
> On PowerPC, FUNCTION_TRACER selects FRAME_POINTER, even
> though the architecture does not support it.
>
> This causes the following warning:
> warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && FUNCTION_TRACER && KMEMCHECK) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300) || ARCH_WANT_FRAME_POINTERS)
>
> So remove the warning by adding the extra condition
> "if !PPC" to FUNCTION_TRACER for FRAME_POINTER selection
I'll queue it up for 3.4, if that's fine with you.
Thanks,
-- Steve
>
> Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
> ---
> kernel/trace/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 2ad39e5..fbdec2e 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -141,7 +141,7 @@ if FTRACE
> config FUNCTION_TRACER
> bool "Kernel Function Tracer"
> depends on HAVE_FUNCTION_TRACER
> - select FRAME_POINTER if !ARM_UNWIND && !S390 && !MICROBLAZE
> + select FRAME_POINTER if !ARM_UNWIND && !PPC && !S390 && !MICROBLAZE
> select KALLSYMS
> select GENERIC_TRACER
> select CONTEXT_SWITCH_TRACER
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/urgent] tracing: Do not select FRAME_POINTER on PPC
2012-02-27 8:08 [PATCH] tracing: don't select FRAME_POINTER on PPC Gerlando Falauto
2012-02-27 13:37 ` Steven Rostedt
@ 2012-03-22 21:17 ` tip-bot for Gerlando Falauto
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Gerlando Falauto @ 2012-03-22 21:17 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, linux-kernel, hpa, mingo, fweisbec, rostedt, tglx,
gerlando.falauto
Commit-ID: 8c9cf542b8a66c231747a550573d910daf17f0e9
Gitweb: http://git.kernel.org/tip/8c9cf542b8a66c231747a550573d910daf17f0e9
Author: Gerlando Falauto <gerlando.falauto@keymile.com>
AuthorDate: Mon, 27 Feb 2012 09:08:21 +0100
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Mon, 27 Feb 2012 08:45:11 -0500
tracing: Do not select FRAME_POINTER on PPC
On PowerPC, FUNCTION_TRACER selects FRAME_POINTER, even
though the architecture does not support it.
This causes the following warning:
warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && FUNCTION_TRACER && KMEMCHECK) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300) || ARCH_WANT_FRAME_POINTERS)
So remove the warning by adding the extra condition
"if !PPC" to FUNCTION_TRACER for FRAME_POINTER selection
Link: http://lkml.kernel.org/r/1330330101-8618-1-git-send-email-gerlando.falauto@keymile.com
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index cd31345..a1d2849 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -141,7 +141,7 @@ if FTRACE
config FUNCTION_TRACER
bool "Kernel Function Tracer"
depends on HAVE_FUNCTION_TRACER
- select FRAME_POINTER if !ARM_UNWIND && !S390 && !MICROBLAZE
+ select FRAME_POINTER if !ARM_UNWIND && !PPC && !S390 && !MICROBLAZE
select KALLSYMS
select GENERIC_TRACER
select CONTEXT_SWITCH_TRACER
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-22 21:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-27 8:08 [PATCH] tracing: don't select FRAME_POINTER on PPC Gerlando Falauto
2012-02-27 13:37 ` Steven Rostedt
2012-03-22 21:17 ` [tip:perf/urgent] tracing: Do not " tip-bot for Gerlando Falauto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).