* [PATCH] perf timechart: Use tid not pid for COMM change
@ 2010-01-16 20:53 Arjan van de Ven
2010-01-17 6:58 ` [tip:perf/urgent] " tip-bot for Arjan van de Ven
0 siblings, 1 reply; 2+ messages in thread
From: Arjan van de Ven @ 2010-01-16 20:53 UTC (permalink / raw)
To: linux-kernel; +Cc: mingo
>From 3e519cea7bbc7c6a3c07e3a24e9f33bf15305516 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Sat, 16 Jan 2010 12:51:30 -0800
Subject: [PATCH] perf timechart: Use tid not pid for COMM change
A process that changes its comm field, does this on a per kernel
task struct basis. The timechart tool used, incorrectly, the pid to track
this, and should have used the tid instead...
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
CC: stable@kernel.org
---
tools/perf/builtin-timechart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index a589a43..3f8bbcf 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -280,7 +280,7 @@ static u64 cpus_pstate_state[MAX_CPUS];
static int process_comm_event(event_t *event, struct perf_session *session __used)
{
- pid_set_comm(event->comm.pid, event->comm.comm);
+ pid_set_comm(event->comm.tid, event->comm.comm);
return 0;
}
--
1.6.2.5
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/urgent] perf timechart: Use tid not pid for COMM change
2010-01-16 20:53 [PATCH] perf timechart: Use tid not pid for COMM change Arjan van de Ven
@ 2010-01-17 6:58 ` tip-bot for Arjan van de Ven
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Arjan van de Ven @ 2010-01-17 6:58 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, acme, paulus, hpa, mingo, a.p.zijlstra, arjan,
efault, fweisbec, stable, tglx, mingo
Commit-ID: 8f06d7e6e1bbfb32698d6d455583ab7460c090e2
Gitweb: http://git.kernel.org/tip/8f06d7e6e1bbfb32698d6d455583ab7460c090e2
Author: Arjan van de Ven <arjan@linux.intel.com>
AuthorDate: Sat, 16 Jan 2010 12:53:19 -0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 17 Jan 2010 07:16:36 +0100
perf timechart: Use tid not pid for COMM change
A process that changes its comm field, does this on a per kernel
task struct basis. The timechart tool used, incorrectly, the pid
to track this, and should have used the tid instead...
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
CC: <stable@kernel.org>
LKML-Reference: <20100116125319.34ac3edd@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
tools/perf/builtin-timechart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index a589a43..3f8bbcf 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -280,7 +280,7 @@ static u64 cpus_pstate_state[MAX_CPUS];
static int process_comm_event(event_t *event, struct perf_session *session __used)
{
- pid_set_comm(event->comm.pid, event->comm.comm);
+ pid_set_comm(event->comm.tid, event->comm.comm);
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-17 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-16 20:53 [PATCH] perf timechart: Use tid not pid for COMM change Arjan van de Ven
2010-01-17 6:58 ` [tip:perf/urgent] " tip-bot for Arjan van de Ven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).