* [PATCH tip 1/1] perf report: Don't show unresolved DSOs and symbols when -S/-d is used
@ 2009-08-12 21:19 Arnaldo Carvalho de Melo
2009-08-13 10:21 ` [tip:perfcounters/urgent] " tip-bot for Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2009-08-12 21:19 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Peter Zijlstra, Linux Kernel Mailing List
We're interested in just those symbols/DSOs, so filter out the
unresolved ones.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-report.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 58a4f08..6321951 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1340,10 +1340,11 @@ process_sample_event(event_t *event, unsigned long offset, unsigned long head)
if (show & show_mask) {
struct symbol *sym = resolve_symbol(thread, &map, &dso, &ip);
- if (dso_list && dso && dso->name && !strlist__has_entry(dso_list, dso->name))
+ if (dso_list && (!dso || !dso->name ||
+ !strlist__has_entry(dso_list, dso->name)))
return 0;
- if (sym_list && sym && !strlist__has_entry(sym_list, sym->name))
+ if (sym_list && (!sym || !strlist__has_entry(sym_list, sym->name)))
return 0;
if (hist_entry__add(thread, map, dso, sym, ip, chain, level, period)) {
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perfcounters/urgent] perf report: Don't show unresolved DSOs and symbols when -S/-d is used
2009-08-12 21:19 [PATCH tip 1/1] perf report: Don't show unresolved DSOs and symbols when -S/-d is used Arnaldo Carvalho de Melo
@ 2009-08-13 10:21 ` tip-bot for Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Arnaldo Carvalho de Melo @ 2009-08-13 10:21 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, acme, hpa, mingo, peterz, tglx, mingo
Commit-ID: 8fd101f20bdf771949a8f3a5a779877d09b2fb56
Gitweb: http://git.kernel.org/tip/8fd101f20bdf771949a8f3a5a779877d09b2fb56
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Wed, 12 Aug 2009 18:19:57 -0300
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 13 Aug 2009 12:05:52 +0200
perf report: Don't show unresolved DSOs and symbols when -S/-d is used
We're interested in just those symbols/DSOs, so filter out the
unresolved ones.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <20090812211957.GE3495@ghostprotocols.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
tools/perf/builtin-report.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 23e1457..b53a60f 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1590,10 +1590,11 @@ process_sample_event(event_t *event, unsigned long offset, unsigned long head)
if (show & show_mask) {
struct symbol *sym = resolve_symbol(thread, &map, &dso, &ip);
- if (dso_list && dso && dso->name && !strlist__has_entry(dso_list, dso->name))
+ if (dso_list && (!dso || !dso->name ||
+ !strlist__has_entry(dso_list, dso->name)))
return 0;
- if (sym_list && sym && !strlist__has_entry(sym_list, sym->name))
+ if (sym_list && (!sym || !strlist__has_entry(sym_list, sym->name)))
return 0;
if (hist_entry__add(thread, map, dso, sym, ip, chain, level, period)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-13 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-12 21:19 [PATCH tip 1/1] perf report: Don't show unresolved DSOs and symbols when -S/-d is used Arnaldo Carvalho de Melo
2009-08-13 10:21 ` [tip:perfcounters/urgent] " tip-bot for Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).