* linux-next: build failure after merge of the tip tree
@ 2016-07-18 8:29 Stephen Rothwell
2016-07-18 14:27 ` Paul Gortmaker
2016-07-19 8:00 ` [tip:x86/headers] x86/headers: Include spinlock_types.h in x8664_ksyms_64.c for missing spinlock_t tip-bot for Stephen Rothwell
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Rothwell @ 2016-07-18 8:29 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
Cc: linux-next, linux-kernel, Paul Gortmaker
Hi all,
After merging the tip tree, today's linux-next build (x86_64 allnoconfig)
failed like this:
In file included from arch/x86/kernel/x8664_ksyms_64.c:10:0:
arch/x86/include/asm/pgtable.h:38:8: error: unknown type name 'spinlock_t'
extern spinlock_t pgd_lock;
^
Probably caused by commit
186f43608a5c ("x86/kernel: Audit and remove any unnecessary uses of module.h")
I added this patch for today (maybe adding the include to
arch/x86/include/asm/pgtable.h would be better?):
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 18 Jul 2016 18:23:24 +1000
Subject: [PATCH] x86/kernel: include spinlock_types.h for missing spinlock_t
Fixes: 186f43608a5c ("x86/kernel: Audit and remove any unnecessary uses of module.h")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/x86/kernel/x8664_ksyms_64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/x8664_ksyms_64.c b/arch/x86/kernel/x8664_ksyms_64.c
index f6d30fedcc03..95e49f6e4fc3 100644
--- a/arch/x86/kernel/x8664_ksyms_64.c
+++ b/arch/x86/kernel/x8664_ksyms_64.c
@@ -2,6 +2,7 @@
All C exports should go in the respective C files. */
#include <linux/export.h>
+#include <linux/spinlock_types.h>
#include <linux/smp.h>
#include <net/checksum.h>
--
2.8.1
--
Cheers,
Stephen Rothwell
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: linux-next: build failure after merge of the tip tree
2016-07-18 8:29 linux-next: build failure after merge of the tip tree Stephen Rothwell
@ 2016-07-18 14:27 ` Paul Gortmaker
2016-07-19 8:00 ` [tip:x86/headers] x86/headers: Include spinlock_types.h in x8664_ksyms_64.c for missing spinlock_t tip-bot for Stephen Rothwell
1 sibling, 0 replies; 3+ messages in thread
From: Paul Gortmaker @ 2016-07-18 14:27 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
linux-next, linux-kernel
[linux-next: build failure after merge of the tip tree] On 18/07/2016 (Mon 18:29) Stephen Rothwell wrote:
> Hi all,
>
> After merging the tip tree, today's linux-next build (x86_64 allnoconfig)
> failed like this:
>
> In file included from arch/x86/kernel/x8664_ksyms_64.c:10:0:
> arch/x86/include/asm/pgtable.h:38:8: error: unknown type name 'spinlock_t'
> extern spinlock_t pgd_lock;
> ^
>
> Probably caused by commit
>
> 186f43608a5c ("x86/kernel: Audit and remove any unnecessary uses of module.h")
Wondering why I didn't see this, when I _thought_ I did the same
coverage, I learned an interesting thing. I'd been doing
make ARCH=i386 allnoconfig
make allnoconfig
...figuring on x86_64 host that I'd need to explicitly choose i386 and
that w/o an ARCH specified, I'd get the native arch... Not so. I just
end up doing the i386 arch coverage twice. :-( I'll go out on a limb
here and guess I'm not the only person to fall into that trap.
I'll now be using:
make ARCH=i386 allnoconfig
make ARCH=x86_64 allnoconfig
Thanks Stephen for the fix and for helping find this gap in my tests.
If my build coverage moves to Power like yours, I'll still be good. :)
Paul.
--
>
> I added this patch for today (maybe adding the include to
> arch/x86/include/asm/pgtable.h would be better?):
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 18 Jul 2016 18:23:24 +1000
> Subject: [PATCH] x86/kernel: include spinlock_types.h for missing spinlock_t
>
> Fixes: 186f43608a5c ("x86/kernel: Audit and remove any unnecessary uses of module.h")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/x86/kernel/x8664_ksyms_64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kernel/x8664_ksyms_64.c b/arch/x86/kernel/x8664_ksyms_64.c
> index f6d30fedcc03..95e49f6e4fc3 100644
> --- a/arch/x86/kernel/x8664_ksyms_64.c
> +++ b/arch/x86/kernel/x8664_ksyms_64.c
> @@ -2,6 +2,7 @@
> All C exports should go in the respective C files. */
>
> #include <linux/export.h>
> +#include <linux/spinlock_types.h>
> #include <linux/smp.h>
>
> #include <net/checksum.h>
> --
> 2.8.1
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/headers] x86/headers: Include spinlock_types.h in x8664_ksyms_64.c for missing spinlock_t
2016-07-18 8:29 linux-next: build failure after merge of the tip tree Stephen Rothwell
2016-07-18 14:27 ` Paul Gortmaker
@ 2016-07-19 8:00 ` tip-bot for Stephen Rothwell
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Stephen Rothwell @ 2016-07-19 8:00 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, sfr, paul.gortmaker, hpa, torvalds, mingo, tglx, peterz
Commit-ID: a203800d97ed635c504b1774dfffee6e7abf95f9
Gitweb: http://git.kernel.org/tip/a203800d97ed635c504b1774dfffee6e7abf95f9
Author: Stephen Rothwell <sfr@canb.auug.org.au>
AuthorDate: Mon, 18 Jul 2016 18:23:24 +1000
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 19 Jul 2016 09:59:07 +0200
x86/headers: Include spinlock_types.h in x8664_ksyms_64.c for missing spinlock_t
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-next@vger.kernel.org
Fixes: 186f43608a5c ("x86/kernel: Audit and remove any unnecessary uses of module.h")
Link: http://lkml.kernel.org/r/20160718182922.7b41f923@canb.auug.org.au
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/x8664_ksyms_64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/x8664_ksyms_64.c b/arch/x86/kernel/x8664_ksyms_64.c
index 099a4db..a2cca5d 100644
--- a/arch/x86/kernel/x8664_ksyms_64.c
+++ b/arch/x86/kernel/x8664_ksyms_64.c
@@ -2,6 +2,7 @@
All C exports should go in the respective C files. */
#include <linux/export.h>
+#include <linux/spinlock_types.h>
#include <linux/smp.h>
#include <net/checksum.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-19 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-18 8:29 linux-next: build failure after merge of the tip tree Stephen Rothwell
2016-07-18 14:27 ` Paul Gortmaker
2016-07-19 8:00 ` [tip:x86/headers] x86/headers: Include spinlock_types.h in x8664_ksyms_64.c for missing spinlock_t tip-bot for Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).