linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf: Compare JOBS to 0 after grep
@ 2015-02-18 23:59 David Ahern
  2015-03-03  6:21 ` [tip:perf/core] perf tools: " tip-bot for David Ahern
  0 siblings, 1 reply; 2+ messages in thread
From: David Ahern @ 2015-02-18 23:59 UTC (permalink / raw)
  To: acme, linux-kernel; +Cc: David Ahern

If JOBS is not by user perf tries to autodetect the number by grepping the
number of CPUs from /proc/cpuinfo. 'grep -c' will always return an integer
so after this command JOBS should be compared to 0, not "".

Signed-off-by: David Ahern <david.ahern@oracle.com>
---
 tools/perf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index cb2e5868c8e8..d5020aeb5626 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -25,7 +25,7 @@ unexport MAKEFLAGS
 #
 ifeq ($(JOBS),)
   JOBS := $(shell grep -c ^processor /proc/cpuinfo 2>/dev/null)
-  ifeq ($(JOBS),)
+  ifeq ($(JOBS),0)
     JOBS := 1
   endif
 endif
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:perf/core] perf tools: Compare JOBS to 0 after grep
  2015-02-18 23:59 [PATCH] perf: Compare JOBS to 0 after grep David Ahern
@ 2015-03-03  6:21 ` tip-bot for David Ahern
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for David Ahern @ 2015-03-03  6:21 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: mingo, acme, tglx, hpa, linux-kernel, david.ahern

Commit-ID:  c65568c5456e5216e5467e81d1e04c1f5bdd453f
Gitweb:     http://git.kernel.org/tip/c65568c5456e5216e5467e81d1e04c1f5bdd453f
Author:     David Ahern <david.ahern@oracle.com>
AuthorDate: Wed, 18 Feb 2015 18:59:31 -0500
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 2 Mar 2015 11:51:00 -0300

perf tools: Compare JOBS to 0 after grep

If JOBS is not by user perf tries to autodetect the number by grepping
the number of CPUs from /proc/cpuinfo. 'grep -c' will always return an
integer so after this command JOBS should be compared to 0, not "".

Signed-off-by: David Ahern <david.ahern@oracle.com>
Link: http://lkml.kernel.org/r/1424303971-91904-1-git-send-email-david.ahern@oracle.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index cb2e586..d5020ae 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -25,7 +25,7 @@ unexport MAKEFLAGS
 #
 ifeq ($(JOBS),)
   JOBS := $(shell grep -c ^processor /proc/cpuinfo 2>/dev/null)
-  ifeq ($(JOBS),)
+  ifeq ($(JOBS),0)
     JOBS := 1
   endif
 endif

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-03  6:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-18 23:59 [PATCH] perf: Compare JOBS to 0 after grep David Ahern
2015-03-03  6:21 ` [tip:perf/core] perf tools: " tip-bot for David Ahern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).