* [PATCH][V2] x86/uv: remove redundant check of p == q
@ 2018-07-31 9:09 Colin King
2018-08-02 12:31 ` [tip:x86/platform] x86/platform/UV: Remove " tip-bot for Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-07-31 9:09 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The check for p == q is dead code because the proceeding switch
statements jump to the end of the outer for-loop with continue
statements. Remove the dead code.
Detected by CoverityScan, CID#145071 ("Structurally dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/platform/uv/tlb_uv.c | 2 --
1 file changed, 2 deletions(-)
---
V2: fix spelling mistake in commit message "Structurally"
diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index ca446da48fd2..e26dfad507c8 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1607,8 +1607,6 @@ static int parse_tunables_write(struct bau_control *bcp, char *instr,
*tunables[cnt].tunp = val;
continue;
}
- if (q == p)
- break;
}
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/platform] x86/platform/UV: Remove redundant check of p == q
2018-07-31 9:09 [PATCH][V2] x86/uv: remove redundant check of p == q Colin King
@ 2018-08-02 12:31 ` tip-bot for Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Colin Ian King @ 2018-08-02 12:31 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, tglx, mingo, colin.king, hpa
Commit-ID: d79d024820f2e522ab30b5e6662c245f887c752b
Gitweb: https://git.kernel.org/tip/d79d024820f2e522ab30b5e6662c245f887c752b
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Tue, 31 Jul 2018 10:09:38 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 2 Aug 2018 14:25:41 +0200
x86/platform/UV: Remove redundant check of p == q
The check for p == q is dead code because the proceeding switch
statements jump to the end of the outer for-loop with continue
statements. Remove the dead code.
Detected by CoverityScan, CID#145071 ("Structurally dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: kernel-janitors@vger.kernel.org
Link: https://lkml.kernel.org/r/20180731090938.11856-1-colin.king@canonical.com
---
arch/x86/platform/uv/tlb_uv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index ca446da48fd2..e26dfad507c8 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1607,8 +1607,6 @@ static int parse_tunables_write(struct bau_control *bcp, char *instr,
*tunables[cnt].tunp = val;
continue;
}
- if (q == p)
- break;
}
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-02 12:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-31 9:09 [PATCH][V2] x86/uv: remove redundant check of p == q Colin King
2018-08-02 12:31 ` [tip:x86/platform] x86/platform/UV: Remove " tip-bot for Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).