linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86: memblock: move mem_hole_size() to .init
@ 2012-02-28 15:16 Jiri Kosina
  2012-02-28 20:07 ` Tejun Heo
  2012-03-04  2:07 ` [tip:x86/urgent] x86, memblock: Move " tip-bot for Jiri Kosina
  0 siblings, 2 replies; 4+ messages in thread
From: Jiri Kosina @ 2012-02-28 15:16 UTC (permalink / raw)
  To: H. Peter Anvin, Ingo Molnar, Tejun Heo; +Cc: linux-kernel, x86

mem_hole_size() is being called only from __init-marked functions, and as 
such should be moved to .init section as well. Fixes this warning:

WARNING: vmlinux.o(.text+0x35511): Section mismatch in reference from the function mem_hole_size() to the function .init.text:absent_pages_in_range()

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 arch/x86/mm/numa_emulation.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/numa_emulation.c b/arch/x86/mm/numa_emulation.c
index 46db568..2fff651 100644
--- a/arch/x86/mm/numa_emulation.c
+++ b/arch/x86/mm/numa_emulation.c
@@ -28,7 +28,7 @@ static int __init emu_find_memblk_by_nid(int nid, const struct numa_meminfo *mi)
 	return -ENOENT;
 }
 
-static u64 mem_hole_size(u64 start, u64 end)
+static u64 __init mem_hole_size(u64 start, u64 end)
 {
 	unsigned long start_pfn = PFN_UP(start);
 	unsigned long end_pfn = PFN_DOWN(end);
-- 
1.7.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] x86: memblock: move mem_hole_size() to .init
  2012-02-28 15:16 [PATCH] x86: memblock: move mem_hole_size() to .init Jiri Kosina
@ 2012-02-28 20:07 ` Tejun Heo
  2012-03-03 22:40   ` Jiri Kosina
  2012-03-04  2:07 ` [tip:x86/urgent] x86, memblock: Move " tip-bot for Jiri Kosina
  1 sibling, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2012-02-28 20:07 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: H. Peter Anvin, Ingo Molnar, linux-kernel, x86

On Tue, Feb 28, 2012 at 04:16:33PM +0100, Jiri Kosina wrote:
> mem_hole_size() is being called only from __init-marked functions, and as 
> such should be moved to .init section as well. Fixes this warning:
> 
> WARNING: vmlinux.o(.text+0x35511): Section mismatch in reference from the function mem_hole_size() to the function .init.text:absent_pages_in_range()
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] x86: memblock: move mem_hole_size() to .init
  2012-02-28 20:07 ` Tejun Heo
@ 2012-03-03 22:40   ` Jiri Kosina
  0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2012-03-03 22:40 UTC (permalink / raw)
  To: Tejun Heo; +Cc: H. Peter Anvin, Ingo Molnar, linux-kernel, x86

On Wed, 29 Feb 2012, Tejun Heo wrote:

> > mem_hole_size() is being called only from __init-marked functions, and as 
> > such should be moved to .init section as well. Fixes this warning:
> > 
> > WARNING: vmlinux.o(.text+0x35511): Section mismatch in reference from the function mem_hole_size() to the function .init.text:absent_pages_in_range()
> > 
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> Acked-by: Tejun Heo <tj@kernel.org>

Thanks. Doesn't seem to have been picked up ... Ingo/hpa, I guess it's 
appropriate for -tip?

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86, memblock: Move mem_hole_size() to .init
  2012-02-28 15:16 [PATCH] x86: memblock: move mem_hole_size() to .init Jiri Kosina
  2012-02-28 20:07 ` Tejun Heo
@ 2012-03-04  2:07 ` tip-bot for Jiri Kosina
  1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Jiri Kosina @ 2012-03-04  2:07 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, jkosina, tglx

Commit-ID:  e37aade31601cdb9f078f6663cbf887f391bb110
Gitweb:     http://git.kernel.org/tip/e37aade31601cdb9f078f6663cbf887f391bb110
Author:     Jiri Kosina <jkosina@suse.cz>
AuthorDate: Tue, 28 Feb 2012 16:16:33 +0100
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Sat, 3 Mar 2012 15:51:20 -0800

x86, memblock: Move mem_hole_size() to .init

mem_hole_size() is being called only from __init-marked functions, and as
such should be moved to .init section as well. Fixes this warning:

WARNING: vmlinux.o(.text+0x35511): Section mismatch in reference from the function mem_hole_size() to the function .init.text:absent_pages_in_range()

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Link: http://lkml.kernel.org/r/alpine.LNX.2.00.1202281614450.31150@pobox.suse.cz
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/mm/numa_emulation.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/numa_emulation.c b/arch/x86/mm/numa_emulation.c
index 46db568..2fff651 100644
--- a/arch/x86/mm/numa_emulation.c
+++ b/arch/x86/mm/numa_emulation.c
@@ -28,7 +28,7 @@ static int __init emu_find_memblk_by_nid(int nid, const struct numa_meminfo *mi)
 	return -ENOENT;
 }
 
-static u64 mem_hole_size(u64 start, u64 end)
+static u64 __init mem_hole_size(u64 start, u64 end)
 {
 	unsigned long start_pfn = PFN_UP(start);
 	unsigned long end_pfn = PFN_DOWN(end);

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-04  2:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-28 15:16 [PATCH] x86: memblock: move mem_hole_size() to .init Jiri Kosina
2012-02-28 20:07 ` Tejun Heo
2012-03-03 22:40   ` Jiri Kosina
2012-03-04  2:07 ` [tip:x86/urgent] x86, memblock: Move " tip-bot for Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).