* [PATCH] irqchip: omap-intc: Remove duplicate setup for IRQ chip type handler
@ 2015-12-21 8:53 Milo Kim
2015-12-29 11:05 ` [tip:irq/core] irqchip/omap-intc: " tip-bot for Milo Kim
0 siblings, 1 reply; 2+ messages in thread
From: Milo Kim @ 2015-12-21 8:53 UTC (permalink / raw)
To: tony, tglx; +Cc: Milo Kim, Jason Cooper, Marc Zyngier, linux-omap, linux-kernel
Some OMAP interrupt controllers use generic level detection, so
handle_level_irq() is used as the chip type handler.
Allocated IRQ chip type handler doesn't need to set it again because
irq_alloc_domain_generic_chips() has already registered it.
Tested with BeagleBoneBlack Rev C.
Cc: Tony Lindgren <tony@atomide.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-omap@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Milo Kim <milo.kim@ti.com>
---
drivers/irqchip/irq-omap-intc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/irqchip/irq-omap-intc.c b/drivers/irqchip/irq-omap-intc.c
index 8587d0f..ed25175 100644
--- a/drivers/irqchip/irq-omap-intc.c
+++ b/drivers/irqchip/irq-omap-intc.c
@@ -207,7 +207,6 @@ static int __init omap_alloc_gc_of(struct irq_domain *d, void __iomem *base)
ct = gc->chip_types;
ct->type = IRQ_TYPE_LEVEL_MASK;
- ct->handler = handle_level_irq;
ct->chip.irq_ack = omap_mask_ack_irq;
ct->chip.irq_mask = irq_gc_mask_disable_reg;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:irq/core] irqchip/omap-intc: Remove duplicate setup for IRQ chip type handler
2015-12-21 8:53 [PATCH] irqchip: omap-intc: Remove duplicate setup for IRQ chip type handler Milo Kim
@ 2015-12-29 11:05 ` tip-bot for Milo Kim
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Milo Kim @ 2015-12-29 11:05 UTC (permalink / raw)
To: linux-tip-commits
Cc: tony, linux-kernel, mingo, tglx, marc.zyngier, milo.kim, jason, hpa
Commit-ID: fee48dfcd76b21b9a7117c3014e1345697ff08ec
Gitweb: http://git.kernel.org/tip/fee48dfcd76b21b9a7117c3014e1345697ff08ec
Author: Milo Kim <milo.kim@ti.com>
AuthorDate: Mon, 21 Dec 2015 17:53:14 +0900
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 29 Dec 2015 11:58:54 +0100
irqchip/omap-intc: Remove duplicate setup for IRQ chip type handler
Some OMAP interrupt controllers use generic level detection, so
handle_level_irq() is used as the chip type handler.
Allocated IRQ chip type handler doesn't need to set it again because
irq_alloc_domain_generic_chips() has already registered it.
Tested with BeagleBoneBlack Rev C.
Signed-off-by: Milo Kim <milo.kim@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-omap@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/1450687994-12580-1-git-send-email-milo.kim@ti.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-omap-intc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/irqchip/irq-omap-intc.c b/drivers/irqchip/irq-omap-intc.c
index 8587d0f..ed25175 100644
--- a/drivers/irqchip/irq-omap-intc.c
+++ b/drivers/irqchip/irq-omap-intc.c
@@ -207,7 +207,6 @@ static int __init omap_alloc_gc_of(struct irq_domain *d, void __iomem *base)
ct = gc->chip_types;
ct->type = IRQ_TYPE_LEVEL_MASK;
- ct->handler = handle_level_irq;
ct->chip.irq_ack = omap_mask_ack_irq;
ct->chip.irq_mask = irq_gc_mask_disable_reg;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-29 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-21 8:53 [PATCH] irqchip: omap-intc: Remove duplicate setup for IRQ chip type handler Milo Kim
2015-12-29 11:05 ` [tip:irq/core] irqchip/omap-intc: " tip-bot for Milo Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).