linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yassine Oudjana <y.oudjana@protonmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	devicetree@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re:  [PATCH] media: dt-bindings: media: venus: Add firmware-name
Date: Wed, 14 Jul 2021 18:13:33 +0000	[thread overview]
Message-ID: <w_oXpbK_lWn1_5cR6AJDWVC_MW4ykO44yTR61UCxS-ifxbyjTmlqksj1DJYERqVyvQBAnxLgJ5-7JEDC8CjgUnuLq7kJbTYVrIVsdxt_D-w=@protonmail.com> (raw)

On Wednesday, July 14th, 2021 at 10:03 PM, Rob Herring <robh@kernel.org> wrote:

> On Tue, Jun 22, 2021 at 04:20:24PM +0000, Yassine Oudjana wrote:
>
> > Date: Tue, 22 Jun 2021 20:08:25 +0400
> >
> > Subject: [PATCH] media: dt-bindings: media: venus: Add firmware-name
> >
> > Support for parsing the firmware-name property was added a while ago 1,
> >
> > but the dt-bindings were never updated with the new property. This patch
> >
> > adds it to all venus dt-bindings.
> >
> > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com
> >
> > .../devicetree/bindings/media/qcom,msm8916-venus.yaml | 5 +++++
> >
> > .../devicetree/bindings/media/qcom,msm8996-venus.yaml | 5 +++++
> >
> > .../devicetree/bindings/media/qcom,sc7180-venus.yaml | 5 +++++
> >
> > .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 5 +++++
> >
> > .../devicetree/bindings/media/qcom,sdm845-venus.yaml | 5 +++++
> >
> > 5 files changed, 25 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
> >
> > index 59ab16ad12f1..cb1b866d9c37 100644
> >
> > --- a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
> >
> > +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
> >
> > @@ -80,6 +80,11 @@ properties:
> >
> > required:
> >
> > - iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
>
> Not an array.
>
Noted.

> Is there a specific pattern and/or default name you can specify?
>
The pattern is usually something like "qcom/<soc>/<device>/venus.mbn", but it can be any path really.
The default would be to not set this property.

> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
> >
> >     index 199f45217b4a..b8809325138f 100644
> >
> >     --- a/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
> >
> >     +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
> >
> >     @@ -107,6 +107,11 @@ properties:
> >
> >     required:
> >     -   iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> >
> >     index 04013e5dd044..ffd3e2850366 100644
> >
> >     --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> >
> >     +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> >
> >     @@ -99,6 +99,11 @@ properties:
> >
> >     required:
> >     -   iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> >
> >     index 04b9af4db191..cd7a5e1374ce 100644
> >
> >     --- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> >
> >     +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> >
> >     @@ -94,6 +94,11 @@ properties:
> >
> >     required:
> >     -   iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml
> >
> >     index 680f37726fdf..ae256238a637 100644
> >
> >     --- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml
> >
> >     +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml
> >
> >     @@ -108,6 +108,11 @@ properties:
> >
> >     required:
> >     -   iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     --
> >
> >     2.32.0

             reply	other threads:[~2021-07-14 18:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 18:13 Yassine Oudjana [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-06-22 16:25 [PATCH] media: dt-bindings: media: venus: Add firmware-name Yassine Oudjana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='w_oXpbK_lWn1_5cR6AJDWVC_MW4ykO44yTR61UCxS-ifxbyjTmlqksj1DJYERqVyvQBAnxLgJ5-7JEDC8CjgUnuLq7kJbTYVrIVsdxt_D-w=@protonmail.com' \
    --to=y.oudjana@protonmail.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=stanimir.varbanov@linaro.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).