* [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree
@ 2014-06-29 7:49 Fabian Frederick
2014-07-01 7:01 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-29 7:49 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Larry Finger, Jes Sorensen, linux-wireless
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
index c8700b3..8714ae3 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -1270,8 +1270,7 @@ static void update_bcn_wps_ie(struct rtw_adapter *padapter)
pnetwork->IELength = wps_offset + (wps_ielen+2) + remainder_ielen;
}
- if (pbackup_remainder_ie)
- kfree(pbackup_remainder_ie);
+ kfree(pbackup_remainder_ie);
}
static void update_bcn_p2p_ie(struct rtw_adapter *padapter)
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree
2014-06-29 7:49 [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree Fabian Frederick
@ 2014-07-01 7:01 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2014-07-01 7:01 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Larry Finger, linux-wireless
Fabian Frederick <fabf@skynet.be> writes:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Jes Sorensen <Jes.Sorensen@redhat.com>
> Cc: linux-wireless@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> index c8700b3..8714ae3 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -1270,8 +1270,7 @@ static void update_bcn_wps_ie(struct rtw_adapter *padapter)
> pnetwork->IELength = wps_offset + (wps_ielen+2) + remainder_ielen;
> }
>
> - if (pbackup_remainder_ie)
> - kfree(pbackup_remainder_ie);
> + kfree(pbackup_remainder_ie);
> }
>
> static void update_bcn_p2p_ie(struct rtw_adapter *padapter)
This one is no longer an issue due to other changes in my tree.
Cheers,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-01 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-29 7:49 [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree Fabian Frederick
2014-07-01 7:01 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).