linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: "kwan.huen" <kwan.huen@samsung.com>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
	Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
	Dimitri John Ledkov <dimitri.ledkov@canonical.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH 1/2] added stream id write support
Date: Tue, 21 Apr 2015 09:44:44 -0400	[thread overview]
Message-ID: <x49y4ll8uk3.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1429580863-3451-2-git-send-email-kwan.huen@samsung.com> (kwan huen's message of "Mon, 20 Apr 2015 18:47:42 -0700")

"kwan.huen" <kwan.huen@samsung.com> writes:

> ---
>  drivers/block/nvme-core.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
> index 85b8036..332341a 100644
> --- a/drivers/block/nvme-core.c
> +++ b/drivers/block/nvme-core.c
> @@ -769,6 +769,9 @@ static int nvme_submit_iod(struct nvme_queue *nvmeq, struct nvme_iod *iod,
>  	if (req->cmd_flags & REQ_RAHEAD)
>  		dsmgmt |= NVME_RW_DSM_FREQ_PREFETCH;
>  
> +	if (rq_data_dir(req))
> +		dsmgmt |= bio_get_streamid(req->bio) << 8;
> +

There's no public specification for this, yet.  How many bits are set
aside for the stream id?  Do you need to do bounds checking/input
validation?  What happens on adapters with older firmware when these
bits are set?

Cheers,
Jeff

  reply	other threads:[~2015-04-21 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21  1:47 Write with Stream ID Support kwan.huen
2015-04-21  1:47 ` [PATCH 1/2] added stream id write support kwan.huen
2015-04-21 13:44   ` Jeff Moyer [this message]
2015-04-21 19:03     ` Hingkwan Huen
2015-04-21  1:47 ` [PATCH 2/2] added two nvme commands for open/close streams and garbage collection kwan.huen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49y4ll8uk3.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=axboe@fb.com \
    --cc=dimitri.ledkov@canonical.com \
    --cc=keith.busch@intel.com \
    --cc=kwan.huen@samsung.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=matthew.r.wilcox@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).