From: Hingkwan Huen <kwan.huen@samsung.com>
To: "'Jeff Moyer'" <jmoyer@redhat.com>
Cc: "'Matthew Wilcox'" <matthew.r.wilcox@intel.com>,
"'Keith Busch'" <keith.busch@intel.com>,
"'Jens Axboe'" <axboe@fb.com>,
"'Dimitri John Ledkov'" <dimitri.ledkov@canonical.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org
Subject: RE: [PATCH 1/2] added stream id write support
Date: Tue, 21 Apr 2015 12:03:37 -0700 [thread overview]
Message-ID: <000f01d07c65$e0721b60$a1565220$@samsung.com> (raw)
In-Reply-To: <x49y4ll8uk3.fsf@segfault.boston.devel.redhat.com>
> -----Original Message-----
> From: Jeff Moyer [mailto:jmoyer@redhat.com]
> Sent: Tuesday, April 21, 2015 6:45 AM
> To: kwan.huen
> Cc: Matthew Wilcox; Keith Busch; Jens Axboe; Dimitri John Ledkov; linux-
> nvme@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> api@vger.kernel.org
> Subject: Re: [PATCH 1/2] added stream id write support
>
> "kwan.huen" <kwan.huen@samsung.com> writes:
>
> > ---
> > drivers/block/nvme-core.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
> > index 85b8036..332341a 100644
> > --- a/drivers/block/nvme-core.c
> > +++ b/drivers/block/nvme-core.c
> > @@ -769,6 +769,9 @@ static int nvme_submit_iod(struct nvme_queue
> *nvmeq, struct nvme_iod *iod,
> > if (req->cmd_flags & REQ_RAHEAD)
> > dsmgmt |= NVME_RW_DSM_FREQ_PREFETCH;
> >
> > + if (rq_data_dir(req))
> > + dsmgmt |= bio_get_streamid(req->bio) << 8;
> > +
>
> There's no public specification for this, yet. How many bits are set
aside for
> the stream id? Do you need to do bounds checking/input validation? What
> happens on adapters with older firmware when these bits are set?
>
> Cheers,
> Jeff
Thanks Jeff for the review!
The patch depends on Jens' recent io-streamid patch set, and the new NVMe
spec we are trying to get approved.
The patch is probably still too early and we'll push this again when Jens'
patches are released and the new spec goes public.
Thanks,
kwan
next prev parent reply other threads:[~2015-04-21 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 1:47 Write with Stream ID Support kwan.huen
2015-04-21 1:47 ` [PATCH 1/2] added stream id write support kwan.huen
2015-04-21 13:44 ` Jeff Moyer
2015-04-21 19:03 ` Hingkwan Huen [this message]
2015-04-21 1:47 ` [PATCH 2/2] added two nvme commands for open/close streams and garbage collection kwan.huen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01d07c65$e0721b60$a1565220$@samsung.com' \
--to=kwan.huen@samsung.com \
--cc=axboe@fb.com \
--cc=dimitri.ledkov@canonical.com \
--cc=jmoyer@redhat.com \
--cc=keith.busch@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=matthew.r.wilcox@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).