[PATCHv3 00/11] Fixes and improvements to f_fs and f_midi

[PATCHv3 00/11] Fixes and improvements to f_fs and f_midi

[Michal Nazarewicz]

Resending my previous two sets for f_fs and f_midi.  This time rebased
on top of Felipe’s next branch.

Dan Carpenter (1):
  usb: gadget: f_midi: missing unlock on error path

Du, Changbin (1):
  usb: f_fs: avoid race condition with ffs_epfile_io_complete

Felipe F. Tonello (1):
  usb: gadget: f_midi: remove useless midi reference from port struct

Michal Nazarewicz (8):
  usb: f_fs: fix memory leak when ep changes during transfer
  usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
  usb: f_fs: replace unnecessary goto with a return
  usb: f_fs: refactor ffs_epfile_io
  usb: gadget: f_midi: move some of f_midi_transmit to separate func
  usb: gadget: f_midi: fix in_last_port looping logic
  usb: gadget: f_midi: use flexible array member for gmidi_in_port
    elements
  usb: gadget: f_midi: stash substream in gmidi_in_port structure

 drivers/usb/gadget/function/f_fs.c   | 155 +++++++++++++--------------
 drivers/usb/gadget/function/f_midi.c | 200 ++++++++++++++++-------------------
 2 files changed, 164 insertions(+), 191 deletions(-)

-- 
2.7.0.rc3.207.g0ac5344

Re: [PATCHv3 00/11] Fixes and improvements to f_fs and f_midi

[Felipe Ferreri Tonello]

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

Hi Michal,

On 26/01/16 14:53, Michal Nazarewicz wrote:
> Resending my previous two sets for f_fs and f_midi.  This time rebased
> on top of Felipe’s next branch.
> 
> Dan Carpenter (1):
>   usb: gadget: f_midi: missing unlock on error path
> 
> Du, Changbin (1):
>   usb: f_fs: avoid race condition with ffs_epfile_io_complete
> 
> Felipe F. Tonello (1):
>   usb: gadget: f_midi: remove useless midi reference from port struct
> 
> Michal Nazarewicz (8):
>   usb: f_fs: fix memory leak when ep changes during transfer
>   usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
>   usb: f_fs: replace unnecessary goto with a return
>   usb: f_fs: refactor ffs_epfile_io
>   usb: gadget: f_midi: move some of f_midi_transmit to separate func
>   usb: gadget: f_midi: fix in_last_port looping logic
>   usb: gadget: f_midi: use flexible array member for gmidi_in_port
>     elements
>   usb: gadget: f_midi: stash substream in gmidi_in_port structure

Sorry for the delay, but I will look into your patches related to f_midi
this week.

> 
>  drivers/usb/gadget/function/f_fs.c   | 155 +++++++++++++--------------
>  drivers/usb/gadget/function/f_midi.c | 200 ++++++++++++++++-------------------
>  2 files changed, 164 insertions(+), 191 deletions(-)
> 

-- 
Felipe

[-- Attachment #2: 0x92698E6A.asc --]
[-- Type: application/pgp-keys, Size: 7195 bytes --]

Re: [PATCHv3 00/11] Fixes and improvements to f_fs and f_midi

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]


Hi,

Michal Nazarewicz <mina86@mina86.com> writes:
> Resending my previous two sets for f_fs and f_midi.  This time rebased
> on top of Felipe’s next branch.
>
> Dan Carpenter (1):
>   usb: gadget: f_midi: missing unlock on error path
>
> Du, Changbin (1):
>   usb: f_fs: avoid race condition with ffs_epfile_io_complete
>
> Felipe F. Tonello (1):
>   usb: gadget: f_midi: remove useless midi reference from port struct
>
> Michal Nazarewicz (8):
>   usb: f_fs: fix memory leak when ep changes during transfer
>   usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
>   usb: f_fs: replace unnecessary goto with a return
>   usb: f_fs: refactor ffs_epfile_io
>   usb: gadget: f_midi: move some of f_midi_transmit to separate func
>   usb: gadget: f_midi: fix in_last_port looping logic
>   usb: gadget: f_midi: use flexible array member for gmidi_in_port
>     elements
>   usb: gadget: f_midi: stash substream in gmidi_in_port structure

looks like I don't have these patches in my inbox, care to resend ?

thanks

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCHv3 00/11] Fixes and improvements to f_fs and f_midi

[Michal Nazarewicz]

> Michal Nazarewicz <mina86@mina86.com> writes:
>> Resending my previous two sets for f_fs and f_midi.  This time rebased
>> on top of Felipe’s next branch.
>>
>> Dan Carpenter (1):
>>   usb: gadget: f_midi: missing unlock on error path
>>
>> Du, Changbin (1):
>>   usb: f_fs: avoid race condition with ffs_epfile_io_complete
>>
>> Felipe F. Tonello (1):
>>   usb: gadget: f_midi: remove useless midi reference from port struct
>>
>> Michal Nazarewicz (8):
>>   usb: f_fs: fix memory leak when ep changes during transfer
>>   usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
>>   usb: f_fs: replace unnecessary goto with a return
>>   usb: f_fs: refactor ffs_epfile_io
>>   usb: gadget: f_midi: move some of f_midi_transmit to separate func
>>   usb: gadget: f_midi: fix in_last_port looping logic
>>   usb: gadget: f_midi: use flexible array member for gmidi_in_port
>>     elements
>>   usb: gadget: f_midi: stash substream in gmidi_in_port structure

On Thu, Feb 18 2016, Felipe Balbi wrote:
> looks like I don't have these patches in my inbox, care to resend ?

Patches freshly rebased on your next branch coming right up.  Also
available at:

    git fetch https://github.com/mina86/linux.git for-felipe

-- 
Best regards
Liege of Serenely Enlightened Majesty of Computer Science,
ミハウ “mina86” ナザレヴイツ  <mpn@google.com> <xmpp:mina86@jabber.org>

Re: [PATCHv3 00/11] Fixes and improvements to f_fs and f_midi

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]


Hi,

Michal Nazarewicz <mina86@mina86.com> writes:
>> Michal Nazarewicz <mina86@mina86.com> writes:
>>> Resending my previous two sets for f_fs and f_midi.  This time rebased
>>> on top of Felipe’s next branch.
>>>
>>> Dan Carpenter (1):
>>>   usb: gadget: f_midi: missing unlock on error path
>>>
>>> Du, Changbin (1):
>>>   usb: f_fs: avoid race condition with ffs_epfile_io_complete
>>>
>>> Felipe F. Tonello (1):
>>>   usb: gadget: f_midi: remove useless midi reference from port struct
>>>
>>> Michal Nazarewicz (8):
>>>   usb: f_fs: fix memory leak when ep changes during transfer
>>>   usb: f_fs: fix ffs_epfile_io returning success on req alloc failure
>>>   usb: f_fs: replace unnecessary goto with a return
>>>   usb: f_fs: refactor ffs_epfile_io
>>>   usb: gadget: f_midi: move some of f_midi_transmit to separate func
>>>   usb: gadget: f_midi: fix in_last_port looping logic
>>>   usb: gadget: f_midi: use flexible array member for gmidi_in_port
>>>     elements
>>>   usb: gadget: f_midi: stash substream in gmidi_in_port structure
>
> On Thu, Feb 18 2016, Felipe Balbi wrote:
>> looks like I don't have these patches in my inbox, care to resend ?
>
> Patches freshly rebased on your next branch coming right up.  Also
> available at:
>
>     git fetch https://github.com/mina86/linux.git for-felipe

thanks, I'll fetch your branch and apply the patches individually :-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]