From: Greg Thelen <gthelen@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/13] initramfs: remove redundant dependency on BLK_DEV_INITRD
Date: Sun, 05 Jan 2020 23:44:12 -0800 [thread overview]
Message-ID: <xr93d0bx6ncj.fsf@gthelen.svl.corp.google.com> (raw)
In-Reply-To: <20200104150238.19834-6-masahiroy@kernel.org>
Masahiro Yamada <masahiroy@kernel.org> wrote:
> init/Kconfig includes usr/Kconfig inside the "if BLK_DEV_INITRD" ...
> "endif" block:
>
> if BLK_DEV_INITRD
>
> source "usr/Kconfig"
>
> endif
>
> Hence, all the defines in usr/Kconfig depend on BLK_DEV_INITRD.
>
> Remove the redundant "depends on BLK_DEV_INITRD".
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Greg Thelen <gthelen@google.com>
> ---
>
> Changes in v2: None
>
> usr/Kconfig | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/usr/Kconfig b/usr/Kconfig
> index a6b68503d177..72f50a21c051 100644
> --- a/usr/Kconfig
> +++ b/usr/Kconfig
> @@ -54,7 +54,6 @@ config INITRAMFS_ROOT_GID
>
> config RD_GZIP
> bool "Support initial ramdisk/ramfs compressed using gzip"
> - depends on BLK_DEV_INITRD
> default y
> select DECOMPRESS_GZIP
> help
> @@ -64,7 +63,6 @@ config RD_GZIP
> config RD_BZIP2
> bool "Support initial ramdisk/ramfs compressed using bzip2"
> default y
> - depends on BLK_DEV_INITRD
> select DECOMPRESS_BZIP2
> help
> Support loading of a bzip2 encoded initial ramdisk or cpio buffer
> @@ -73,7 +71,6 @@ config RD_BZIP2
> config RD_LZMA
> bool "Support initial ramdisk/ramfs compressed using LZMA"
> default y
> - depends on BLK_DEV_INITRD
> select DECOMPRESS_LZMA
> help
> Support loading of a LZMA encoded initial ramdisk or cpio buffer
> @@ -81,7 +78,6 @@ config RD_LZMA
>
> config RD_XZ
> bool "Support initial ramdisk/ramfs compressed using XZ"
> - depends on BLK_DEV_INITRD
> default y
> select DECOMPRESS_XZ
> help
> @@ -91,7 +87,6 @@ config RD_XZ
> config RD_LZO
> bool "Support initial ramdisk/ramfs compressed using LZO"
> default y
> - depends on BLK_DEV_INITRD
> select DECOMPRESS_LZO
> help
> Support loading of a LZO encoded initial ramdisk or cpio buffer
> @@ -100,7 +95,6 @@ config RD_LZO
> config RD_LZ4
> bool "Support initial ramdisk/ramfs compressed using LZ4"
> default y
> - depends on BLK_DEV_INITRD
> select DECOMPRESS_LZ4
> help
> Support loading of a LZ4 encoded initial ramdisk or cpio buffer
next prev parent reply other threads:[~2020-01-06 7:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 15:02 [PATCH v2 00/13] initramfs: a lot of cleanups Masahiro Yamada
2020-01-04 15:02 ` [PATCH v2 01/13] initramfs: replace klibcdirs in Makefile with FORCE Masahiro Yamada
2020-01-06 7:33 ` Greg Thelen
2020-01-07 10:46 ` Masahiro Yamada
2020-01-07 17:13 ` hpa
2020-01-04 15:02 ` [PATCH v2 02/13] gen_initramfs_list.sh: remove unused variable 'default_list' Masahiro Yamada
2020-01-06 7:34 ` Greg Thelen
2020-01-04 15:02 ` [PATCH v2 03/13] gen_initramfs_list.sh: fix the tool name in the comment Masahiro Yamada
2020-01-06 7:34 ` Greg Thelen
2020-01-04 15:02 ` [PATCH v2 04/13] initramfs: rename gen_initramfs_list.sh to gen_initramfs.sh Masahiro Yamada
2020-01-06 7:43 ` Greg Thelen
2020-01-06 10:26 ` Masahiro Yamada
2020-01-07 3:02 ` Ben Hutchings
2020-01-07 3:21 ` hpa
2020-01-04 15:02 ` [PATCH v2 05/13] initramfs: remove redundant dependency on BLK_DEV_INITRD Masahiro Yamada
2020-01-06 7:44 ` Greg Thelen [this message]
2020-01-04 15:02 ` [PATCH v2 06/13] initramfs: make compression options not depend on INITRAMFS_SOURCE Masahiro Yamada
2020-01-04 15:02 ` [PATCH v2 07/13] initramfs: make initramfs compression choice non-optional Masahiro Yamada
2020-01-04 15:02 ` [PATCH v2 08/13] initramfs: specify $(src)/gen_initramfs.sh as a prerequisite in Makefile Masahiro Yamada
2020-01-06 7:51 ` Greg Thelen
2020-01-04 15:02 ` [PATCH v2 09/13] initramfs: generate dependency list and cpio at the same time Masahiro Yamada
2020-01-04 15:02 ` [PATCH v2 10/13] initramfs: add default_cpio_list, and delete -d option support Masahiro Yamada
2020-01-04 15:02 ` [PATCH v2 11/13] gen_initramfs.sh: always output cpio even without -o option Masahiro Yamada
2020-01-04 15:02 ` [PATCH v2 12/13] initramfs: refactor the initramfs build rules Masahiro Yamada
2020-01-04 15:02 ` [PATCH v2 13/13] gen_initramfs.sh: remove intermediate cpio_list on errors Masahiro Yamada
2020-01-21 15:59 ` [PATCH v2 00/13] initramfs: a lot of cleanups Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xr93d0bx6ncj.fsf@gthelen.svl.corp.google.com \
--to=gthelen@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab+samsung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).