* [PATCH] scsi: ufs: add fall through annotation
@ 2018-11-26 8:10 Tomas Winkler
2018-11-26 15:56 ` Avri Altman
2018-11-29 2:35 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Tomas Winkler @ 2018-11-26 8:10 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, Vinayak Holikatti,
Avri Altman
Cc: linux-scsi, linux-kernel, Tomas Winkler
Add /* fallthrough */ annotation, to eliminate compilation warning:
warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/scsi/ufs/ufshcd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3807efd895be..b15f5dab0618 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1549,6 +1549,7 @@ int ufshcd_hold(struct ufs_hba *hba, bool async)
* currently running. Hence, fall through to cancel gating
* work and to enable clocks.
*/
+ /* fallthrough */
case CLKS_OFF:
ufshcd_scsi_block_requests(hba);
hba->clk_gating.state = REQ_CLKS_ON;
@@ -1560,6 +1561,7 @@ int ufshcd_hold(struct ufs_hba *hba, bool async)
* fall through to check if we should wait for this
* work to be done or not.
*/
+ /* fallthrough */
case REQ_CLKS_ON:
if (async) {
rc = -EAGAIN;
@@ -4618,6 +4620,7 @@ ufshcd_scsi_cmd_status(struct ufshcd_lrb *lrbp, int scsi_status)
switch (scsi_status) {
case SAM_STAT_CHECK_CONDITION:
ufshcd_copy_sense_data(lrbp);
+ /* fallthrough */
case SAM_STAT_GOOD:
result |= DID_OK << 16 |
COMMAND_COMPLETE << 8 |
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] scsi: ufs: add fall through annotation
2018-11-26 8:10 [PATCH] scsi: ufs: add fall through annotation Tomas Winkler
@ 2018-11-26 15:56 ` Avri Altman
2018-11-29 2:35 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Avri Altman @ 2018-11-26 15:56 UTC (permalink / raw)
To: Tomas Winkler, James E . J . Bottomley, Martin K . Petersen,
Vinayak Holikatti
Cc: linux-scsi, linux-kernel
> -----Original Message-----
> From: Tomas Winkler <tomas.winkler@intel.com>
> Sent: Monday, November 26, 2018 10:11 AM
> To: James E . J . Bottomley <jejb@linux.vnet.ibm.com>; Martin K . Petersen
> <martin.petersen@oracle.com>; Vinayak Holikatti
> <vinholikatti@gmail.com>; Avri Altman <Avri.Altman@wdc.com>
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Tomas Winkler
> <tomas.winkler@intel.com>
> Subject: [PATCH] scsi: ufs: add fall through annotation
>
> Add /* fallthrough */ annotation, to eliminate compilation warning:
> warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: add fall through annotation
2018-11-26 8:10 [PATCH] scsi: ufs: add fall through annotation Tomas Winkler
2018-11-26 15:56 ` Avri Altman
@ 2018-11-29 2:35 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-11-29 2:35 UTC (permalink / raw)
To: Tomas Winkler
Cc: James E . J . Bottomley, Martin K . Petersen, Vinayak Holikatti,
Avri Altman, linux-scsi, linux-kernel
Tomas,
> Add /* fallthrough */ annotation, to eliminate compilation warning:
> warning: this statement may fall through [-Wimplicit-fallthrough=]
Applied to 4.20/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-29 2:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-26 8:10 [PATCH] scsi: ufs: add fall through annotation Tomas Winkler
2018-11-26 15:56 ` Avri Altman
2018-11-29 2:35 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).