* [PATCH] sd: Cleaned up comment references to @sdp argument explanation.
@ 2017-01-12 21:17 John Pittman
2017-01-20 21:59 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: John Pittman @ 2017-01-12 21:17 UTC (permalink / raw)
To: jejb; +Cc: linux-scsi, linux-kernel, John Pittman
In sd.c there are two comment references to 'struct scsi_device *sdp'
as an argument. One of the references has a typo and the other should
be a reference to 'struct device *dev' instead.
Fixed by correcting the typo in the first and changing the explanation
in the second.
Signed-off-by: John Pittman <jpittman@redhat.com>
Edited to
---
drivers/scsi/sd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index b193304..52105d8 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -703,7 +703,7 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
/**
* sd_setup_discard_cmnd - unmap blocks on thinly provisioned device
- * @sdp: scsi device to operate one
+ * @sdp: scsi device to operate on
* @rq: Request to prepare
*
* Will issue either UNMAP or WRITE SAME(16) depending on preference
@@ -3192,7 +3192,7 @@ static int sd_probe(struct device *dev)
* sd_remove - called whenever a scsi disk (previously recognized by
* sd_probe) is detached from the system. It is called (potentially
* multiple times) during sd module unload.
- * @sdp: pointer to mid level scsi device object
+ * @dev: pointer to device object
*
* Note: this function is invoked from the scsi mid-level.
* This function potentially frees up a device name (e.g. /dev/sdc)
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sd: Cleaned up comment references to @sdp argument explanation.
2017-01-12 21:17 [PATCH] sd: Cleaned up comment references to @sdp argument explanation John Pittman
@ 2017-01-20 21:59 ` Martin K. Petersen
0 siblings, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-01-20 21:59 UTC (permalink / raw)
To: John Pittman; +Cc: jejb, linux-scsi, linux-kernel
>>>>> "John" == John Pittman <jpittman@redhat.com> writes:
John> In sd.c there are two comment references to 'struct scsi_device
John> *sdp' as an argument. One of the references has a typo and the
John> other should be a reference to 'struct device *dev' instead.
Applied to 4.11/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] sd: Cleaned up comment references to @sdp argument explanation.
@ 2017-01-12 21:24 John Pittman
0 siblings, 0 replies; 3+ messages in thread
From: John Pittman @ 2017-01-12 21:24 UTC (permalink / raw)
To: jejb; +Cc: linux-scsi, linux-kernel, John Pittman
In sd.c there are two comment references to 'struct scsi_device *sdp'
as an argument. One of the references has a typo and the other should
be a reference to 'struct device *dev' instead.
Fixed by correcting the typo in the first and changing the explanation
in the second.
Signed-off-by: John Pittman <jpittman@redhat.com>
Edited to
---
drivers/scsi/sd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index b193304..52105d8 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -703,7 +703,7 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
/**
* sd_setup_discard_cmnd - unmap blocks on thinly provisioned device
- * @sdp: scsi device to operate one
+ * @sdp: scsi device to operate on
* @rq: Request to prepare
*
* Will issue either UNMAP or WRITE SAME(16) depending on preference
@@ -3192,7 +3192,7 @@ static int sd_probe(struct device *dev)
* sd_remove - called whenever a scsi disk (previously recognized by
* sd_probe) is detached from the system. It is called (potentially
* multiple times) during sd module unload.
- * @sdp: pointer to mid level scsi device object
+ * @dev: pointer to device object
*
* Note: this function is invoked from the scsi mid-level.
* This function potentially frees up a device name (e.g. /dev/sdc)
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-20 21:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-12 21:17 [PATCH] sd: Cleaned up comment references to @sdp argument explanation John Pittman
2017-01-20 21:59 ` Martin K. Petersen
2017-01-12 21:24 John Pittman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).