* [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'
@ 2016-01-25 22:00 Arnd Bergmann
2016-01-27 2:14 ` Martin K. Petersen
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2016-01-25 22:00 UTC (permalink / raw)
To: Martin K. Petersen, James E.J. Bottomley
Cc: Johannes Thumshirn, Tina Ruchandani, Himanshu Madhani, y2038,
linux-scsi, linux-kernel, Dept-Eng QLA2xxx Upstream
From: Tina Ruchandani <ruchandani.tina@gmail.com>
struct register_host_info stores a 64-bit UTC system time timestamp.
This patch removes the use of 'struct timeval' to obtain that timestamp
as its tv_sec value will overflow on 32-bit systems in year 2038 beyond.
The patch uses ktime_get_real_seconds() which returns a 64-bit seconds value.
Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Acked-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Resent with correct author field and added Ack
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c
index b5029e543b91..15dff7099955 100644
--- a/drivers/scsi/qla2xxx/qla_mr.c
+++ b/drivers/scsi/qla2xxx/qla_mr.c
@@ -6,6 +6,7 @@
*/
#include "qla_def.h"
#include <linux/delay.h>
+#include <linux/ktime.h>
#include <linux/pci.h>
#include <linux/ratelimit.h>
#include <linux/vmalloc.h>
@@ -1812,7 +1813,6 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t *fcport, uint16_t fx_type)
struct host_system_info *phost_info;
struct register_host_info *preg_hsi;
struct new_utsname *p_sysid = NULL;
- struct timeval tv;
sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL);
if (!sp)
@@ -1886,8 +1886,7 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t *fcport, uint16_t fx_type)
p_sysid->domainname, DOMNAME_LENGTH);
strncpy(phost_info->hostdriver,
QLA2XXX_VERSION, VERSION_LENGTH);
- do_gettimeofday(&tv);
- preg_hsi->utc = (uint64_t)tv.tv_sec;
+ preg_hsi->utc = (uint64_t)ktime_get_real_seconds();
ql_dbg(ql_dbg_init, vha, 0x0149,
"ISP%04X: Host registration with firmware\n",
ha->pdev->device);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'
2016-01-25 22:00 [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval' Arnd Bergmann
@ 2016-01-27 2:14 ` Martin K. Petersen
2016-04-13 9:32 ` Tina Ruchandani
0 siblings, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2016-01-27 2:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Martin K. Petersen, James E.J. Bottomley, Johannes Thumshirn,
Tina Ruchandani, Himanshu Madhani, y2038, linux-scsi,
linux-kernel, Dept-Eng QLA2xxx Upstream
>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:
Arnd> struct register_host_info stores a 64-bit UTC system time
Arnd> timestamp. This patch removes the use of 'struct timeval' to
Arnd> obtain that timestamp as its tv_sec value will overflow on 32-bit
Arnd> systems in year 2038 beyond. The patch uses
Arnd> ktime_get_real_seconds() which returns a 64-bit seconds value.
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'
2016-01-27 2:14 ` Martin K. Petersen
@ 2016-04-13 9:32 ` Tina Ruchandani
2016-04-15 2:27 ` Martin K. Petersen
0 siblings, 1 reply; 4+ messages in thread
From: Tina Ruchandani @ 2016-04-13 9:32 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Arnd Bergmann, James E.J. Bottomley, Johannes Thumshirn,
Himanshu Madhani, y2038, linux-scsi, linux-kernel,
Dept-Eng QLA2xxx Upstream
>
> Applied to 4.6/scsi-queue.
Hi Martin,
I am not seeing this patch in v4.6-rc3 in Linus's tree. Should I resend this?
Thanks,
Tina
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'
2016-04-13 9:32 ` Tina Ruchandani
@ 2016-04-15 2:27 ` Martin K. Petersen
0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2016-04-15 2:27 UTC (permalink / raw)
To: Tina Ruchandani
Cc: Martin K. Petersen, Arnd Bergmann, James E.J. Bottomley,
Johannes Thumshirn, Himanshu Madhani, y2038, linux-scsi,
linux-kernel, Dept-Eng QLA2xxx Upstream
>>>>> "Tina" == Tina Ruchandani <ruchandani.tina@gmail.com> writes:
Tina,
>> Applied to 4.6/scsi-queue.
Tina> I am not seeing this patch in v4.6-rc3 in Linus's tree.
Not sure how I messed that up. Sorry!
Applied to 4.7/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-15 2:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-25 22:00 [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval' Arnd Bergmann
2016-01-27 2:14 ` Martin K. Petersen
2016-04-13 9:32 ` Tina Ruchandani
2016-04-15 2:27 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).