* [PATCH] scsi: message: fusion: remove variable 'where'
@ 2022-10-31 15:45 Colin Ian King
2022-11-08 2:59 ` Martin K. Petersen
2022-11-17 18:29 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-10-31 15:45 UTC (permalink / raw)
To: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
MPT-FusionLinux.pdl, linux-scsi
Cc: kernel-janitors, linux-kernel
Variable where is just being incremented and it's never used
anywhere else. The variable and the increment are redundant so
remove it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/message/fusion/mptctl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
index 52c7020c9d19..1decd09a08d8 100644
--- a/drivers/message/fusion/mptctl.c
+++ b/drivers/message/fusion/mptctl.c
@@ -2879,7 +2879,6 @@ static struct mpt_pci_driver mptctl_driver = {
static int __init mptctl_init(void)
{
int err;
- int where = 1;
show_mptmod_ver(my_NAME, my_VERSION);
@@ -2898,7 +2897,6 @@ static int __init mptctl_init(void)
/*
* Install our handler
*/
- ++where;
mptctl_id = mpt_register(mptctl_reply, MPTCTL_DRIVER,
"mptctl_reply");
if (!mptctl_id || mptctl_id >= MPT_MAX_PROTOCOL_DRIVERS) {
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: message: fusion: remove variable 'where'
2022-10-31 15:45 [PATCH] scsi: message: fusion: remove variable 'where' Colin Ian King
@ 2022-11-08 2:59 ` Martin K. Petersen
2022-11-17 18:29 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-11-08 2:59 UTC (permalink / raw)
To: Colin Ian King
Cc: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
MPT-FusionLinux.pdl, linux-scsi, kernel-janitors, linux-kernel
Colin,
> Variable where is just being incremented and it's never used anywhere
> else. The variable and the increment are redundant so remove it.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: message: fusion: remove variable 'where'
2022-10-31 15:45 [PATCH] scsi: message: fusion: remove variable 'where' Colin Ian King
2022-11-08 2:59 ` Martin K. Petersen
@ 2022-11-17 18:29 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-11-17 18:29 UTC (permalink / raw)
To: MPT-FusionLinux.pdl, Suganath Prabu Subramani, Colin Ian King,
linux-scsi, Sreekanth Reddy, Sathya Prakash
Cc: Martin K . Petersen, kernel-janitors, linux-kernel
On Mon, 31 Oct 2022 15:45:38 +0000, Colin Ian King wrote:
> Variable where is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
>
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: message: fusion: remove variable 'where'
https://git.kernel.org/mkp/scsi/c/c7cbaab2d464
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-17 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-31 15:45 [PATCH] scsi: message: fusion: remove variable 'where' Colin Ian King
2022-11-08 2:59 ` Martin K. Petersen
2022-11-17 18:29 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).