* [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue
@ 2021-05-31 16:31 ` Bean Huo
2021-05-31 16:36 ` Alim Akhtar
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Bean Huo @ 2021-05-31 16:31 UTC (permalink / raw)
To: alim.akhtar, avri.altman, jejb, martin.petersen, beanhuo,
bvanassche, tomas.winkler, cang
Cc: linux-scsi, linux-kernel
From: Bean Huo <beanhuo@micron.com>
Fix the following W=1 kernel build warning:
drivers/scsi/ufs/ufshcd.c:9773: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Bean Huo <beanhuo@micron.com>
---
drivers/scsi/ufs/ufshcd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 02267b090729..2cdd1f6da670 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -9769,10 +9769,7 @@ static const struct dev_pm_ops ufs_rpmb_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(NULL, ufshcd_rpmb_resume)
};
-/**
- * Describes the ufs rpmb wlun.
- * Used only to send uac.
- */
+/* ufs_rpmb_wlun_template - Describes UFS rpmb wlun. Used only to send uac. */
static struct scsi_driver ufs_rpmb_wlun_template = {
.gendrv = {
.name = "ufs_rpmb_wlun",
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue
2021-05-31 16:31 ` [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue Bean Huo
@ 2021-05-31 16:36 ` Alim Akhtar
2021-05-31 21:03 ` Bart Van Assche
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Alim Akhtar @ 2021-05-31 16:36 UTC (permalink / raw)
To: 'Bean Huo',
avri.altman, jejb, martin.petersen, beanhuo, bvanassche,
tomas.winkler, cang
Cc: linux-scsi, linux-kernel
Hi Bean,
> -----Original Message-----
> From: Bean Huo <huobean@gmail.com>
> Sent: 31 May 2021 22:01
> To: alim.akhtar@samsung.com; avri.altman@wdc.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com; beanhuo@micron.com;
> bvanassche@acm.org; tomas.winkler@intel.com; cang@codeaurora.org
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue
>
> From: Bean Huo <beanhuo@micron.com>
>
> Fix the following W=1 kernel build warning:
>
> drivers/scsi/ufs/ufshcd.c:9773: warning: This comment starts with '/**',
but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/scsi/ufs/ufshcd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
.
.
.
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue
2021-05-31 16:31 ` [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue Bean Huo
2021-05-31 16:36 ` Alim Akhtar
@ 2021-05-31 21:03 ` Bart Van Assche
2021-06-02 3:43 ` Martin K. Petersen
2021-06-08 3:05 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2021-05-31 21:03 UTC (permalink / raw)
To: Bean Huo, alim.akhtar, avri.altman, jejb, martin.petersen,
beanhuo, tomas.winkler, cang
Cc: linux-scsi, linux-kernel
On 5/31/21 9:31 AM, Bean Huo wrote:
> +/* ufs_rpmb_wlun_template - Describes UFS rpmb wlun. Used only to send uac. */
Hi Bean,
For future patches, since RPMB, WLUN and UAC are all abbreviations,
please capitalize these.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue
2021-05-31 16:31 ` [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue Bean Huo
2021-05-31 16:36 ` Alim Akhtar
2021-05-31 21:03 ` Bart Van Assche
@ 2021-06-02 3:43 ` Martin K. Petersen
2021-06-08 3:05 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2021-06-02 3:43 UTC (permalink / raw)
To: Bean Huo
Cc: alim.akhtar, avri.altman, jejb, martin.petersen, beanhuo,
bvanassche, tomas.winkler, cang, linux-scsi, linux-kernel
Bean,
> Fix the following W=1 kernel build warning:
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue
2021-05-31 16:31 ` [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue Bean Huo
` (2 preceding siblings ...)
2021-06-02 3:43 ` Martin K. Petersen
@ 2021-06-08 3:05 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2021-06-08 3:05 UTC (permalink / raw)
To: alim.akhtar, beanhuo, avri.altman, cang, bvanassche, Bean Huo,
tomas.winkler, jejb
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Mon, 31 May 2021 18:31:22 +0200, Bean Huo wrote:
> Fix the following W=1 kernel build warning:
>
> drivers/scsi/ufs/ufshcd.c:9773: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Applied to 5.14/scsi-queue, thanks!
[1/1] scsi: ufs: Fix a kernel-doc related formatting issue
https://git.kernel.org/mkp/scsi/c/f6b414294224
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-08 3:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210531163136epcas5p33bc53d90af17333be4b2805d7ad3155e@epcas5p3.samsung.com>
2021-05-31 16:31 ` [PATCH] scsi: ufs: Fix a kernel-doc related formatting issue Bean Huo
2021-05-31 16:36 ` Alim Akhtar
2021-05-31 21:03 ` Bart Van Assche
2021-06-02 3:43 ` Martin K. Petersen
2021-06-08 3:05 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).