* [PATCH] scsi: myrb: remove redundant assignment to variable timeout
@ 2020-09-29 2:24 Jing Xiangfeng
2020-10-08 2:47 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jing Xiangfeng @ 2020-09-29 2:24 UTC (permalink / raw)
To: hare, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel, jingxiangfeng
The variable timeout has been initialized with a value '0'. The assignment
before while loop is redundant. So remove it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/scsi/myrb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
index b2869c5dd7fb..687a808969ac 100644
--- a/drivers/scsi/myrb.c
+++ b/drivers/scsi/myrb.c
@@ -2732,7 +2732,6 @@ static int DAC960_LA_hw_init(struct pci_dev *pdev,
DAC960_LA_disable_intr(base);
DAC960_LA_ack_hw_mbox_status(base);
udelay(1000);
- timeout = 0;
while (DAC960_LA_init_in_progress(base) &&
timeout < MYRB_MAILBOX_TIMEOUT) {
if (DAC960_LA_read_error_status(base, &error,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: myrb: remove redundant assignment to variable timeout
2020-09-29 2:24 [PATCH] scsi: myrb: remove redundant assignment to variable timeout Jing Xiangfeng
@ 2020-10-08 2:47 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-08 2:47 UTC (permalink / raw)
To: Jing Xiangfeng; +Cc: hare, jejb, martin.petersen, linux-scsi, linux-kernel
Jing,
> The variable timeout has been initialized with a value '0'. The assignment
> before while loop is redundant. So remove it.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: myrb: remove redundant assignment to variable timeout
2020-09-29 2:24 [PATCH] scsi: myrb: remove redundant assignment to variable timeout Jing Xiangfeng
2020-10-08 2:47 ` Martin K. Petersen
@ 2020-10-13 22:42 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-13 22:42 UTC (permalink / raw)
To: jejb, hare, Jing Xiangfeng; +Cc: Martin K . Petersen, linux-kernel, linux-scsi
On Tue, 29 Sep 2020 10:24:58 +0800, Jing Xiangfeng wrote:
> The variable timeout has been initialized with a value '0'. The assignment
> before while loop is redundant. So remove it.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: myrb: Remove redundant assignment to variable timeout
https://git.kernel.org/mkp/scsi/c/5f6dcb55a7fa
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-13 22:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-29 2:24 [PATCH] scsi: myrb: remove redundant assignment to variable timeout Jing Xiangfeng
2020-10-08 2:47 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).