* Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling
2017-03-21 12:19 ` [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling Jaehoon Chung
@ 2017-03-22 13:35 ` Bartlomiej Zolnierkiewicz
2017-03-24 23:19 ` Subhash Jadavani
2017-03-28 1:46 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-03-22 13:35 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-scsi, vinholikatti, martin.petersen, linux-kernel
Hi,
On Tuesday, March 21, 2017 09:19:57 PM Jaehoon Chung wrote:
> There are same conditions for checking whether supporting clkscaling or
> not.
> When ufshcd is supporting clkscaling, active_reqs should be decreased by
> two.
I guess you meant "one" here, not "two"?
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index dc6efbd..f2cbc71 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba,
> }
> if (ufshcd_is_clkscaling_supported(hba))
> hba->clk_scaling.active_reqs--;
> - if (ufshcd_is_clkscaling_supported(hba))
> - hba->clk_scaling.active_reqs--;
> }
>
> /* clear corresponding bits of completed commands */
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling
2017-03-21 12:19 ` [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling Jaehoon Chung
2017-03-22 13:35 ` Bartlomiej Zolnierkiewicz
@ 2017-03-24 23:19 ` Subhash Jadavani
2017-03-28 1:46 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Subhash Jadavani @ 2017-03-24 23:19 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-scsi, vinholikatti, martin.petersen, linux-kernel,
linux-scsi-owner
On 2017-03-21 05:19, Jaehoon Chung wrote:
> There are same conditions for checking whether supporting clkscaling or
> not.
> When ufshcd is supporting clkscaling, active_reqs should be decreased
> by
> two.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index dc6efbd..f2cbc71 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct
> ufs_hba *hba,
> }
> if (ufshcd_is_clkscaling_supported(hba))
> hba->clk_scaling.active_reqs--;
> - if (ufshcd_is_clkscaling_supported(hba))
> - hba->clk_scaling.active_reqs--;
> }
>
> /* clear corresponding bits of completed commands */
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling
2017-03-21 12:19 ` [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling Jaehoon Chung
2017-03-22 13:35 ` Bartlomiej Zolnierkiewicz
2017-03-24 23:19 ` Subhash Jadavani
@ 2017-03-28 1:46 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2017-03-28 1:46 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-scsi, vinholikatti, martin.petersen, linux-kernel
Jaehoon Chung <jh80.chung@samsung.com> writes:
Jaehoon,
> There are same conditions for checking whether supporting clkscaling
> or not. When ufshcd is supporting clkscaling, active_reqs should be
> decreased by two.
Applied to 4.11/scsi-fixes.
Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread