linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: mvumi: Fix error return in mvumi_io_attach()
@ 2020-09-10 12:38 Jing Xiangfeng
  2020-10-03  1:43 ` Martin K. Petersen
  2020-10-07  3:47 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Jing Xiangfeng @ 2020-09-10 12:38 UTC (permalink / raw)
  To: jejb, martin.petersen; +Cc: linux-scsi, linux-kernel, jingxiangfeng

Fix to return error code PTR_ERR() from the error handling case instead
of 0.

Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 drivers/scsi/mvumi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
index 8906aceda4c4..0354898d7cac 100644
--- a/drivers/scsi/mvumi.c
+++ b/drivers/scsi/mvumi.c
@@ -2425,6 +2425,7 @@ static int mvumi_io_attach(struct mvumi_hba *mhba)
 	if (IS_ERR(mhba->dm_thread)) {
 		dev_err(&mhba->pdev->dev,
 			"failed to create device scan thread\n");
+		ret = PTR_ERR(mhba->dm_thread);
 		mutex_unlock(&mhba->sas_discovery_mutex);
 		goto fail_create_thread;
 	}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: mvumi: Fix error return in mvumi_io_attach()
  2020-09-10 12:38 [PATCH] scsi: mvumi: Fix error return in mvumi_io_attach() Jing Xiangfeng
@ 2020-10-03  1:43 ` Martin K. Petersen
  2020-10-07  3:47 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-03  1:43 UTC (permalink / raw)
  To: Jing Xiangfeng; +Cc: jejb, martin.petersen, linux-scsi, linux-kernel


Jing,

> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.

Applied to 5.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: mvumi: Fix error return in mvumi_io_attach()
  2020-09-10 12:38 [PATCH] scsi: mvumi: Fix error return in mvumi_io_attach() Jing Xiangfeng
  2020-10-03  1:43 ` Martin K. Petersen
@ 2020-10-07  3:47 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-07  3:47 UTC (permalink / raw)
  To: Jing Xiangfeng, jejb; +Cc: Martin K . Petersen, linux-kernel, linux-scsi

On Thu, 10 Sep 2020 20:38:48 +0800, Jing Xiangfeng wrote:

> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: mvumi: Fix error return in mvumi_io_attach()
      https://git.kernel.org/mkp/scsi/c/055f15ab2cb4

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-07  3:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 12:38 [PATCH] scsi: mvumi: Fix error return in mvumi_io_attach() Jing Xiangfeng
2020-10-03  1:43 ` Martin K. Petersen
2020-10-07  3:47 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).