* [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check
@ 2021-06-09 9:26 Dan Carpenter
2021-06-10 3:01 ` Martin K. Petersen
2021-06-16 3:48 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-06-09 9:26 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: Martin K. Petersen, Hannes Reinecke, Tomas Henzl, Kashyap Desai,
Himanshu Madhani, linux-scsi, linux-kernel, kernel-janitors
The "mrioc->intr_info" pointer can't be NULL, but if it could then the
second iteration through the loop would Oops. Let's delete the
confusing and impossible NULL check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/mpi3mr/mpi3mr_fw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
index acb2be62080a..40696b75345d 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
@@ -3583,8 +3583,7 @@ static void mpi3mr_free_mem(struct mpi3mr_ioc *mrioc)
for (i = 0; i < mrioc->intr_info_count; i++) {
intr_info = mrioc->intr_info + i;
- if (intr_info)
- intr_info->op_reply_q = NULL;
+ intr_info->op_reply_q = NULL;
}
kfree(mrioc->req_qinfo);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check
2021-06-09 9:26 [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check Dan Carpenter
@ 2021-06-10 3:01 ` Martin K. Petersen
2021-06-16 3:48 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-06-10 3:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, Martin K. Petersen, Hannes Reinecke,
Tomas Henzl, Kashyap Desai, Himanshu Madhani, linux-scsi,
linux-kernel, kernel-janitors
Dan,
> The "mrioc->intr_info" pointer can't be NULL, but if it could then the
> second iteration through the loop would Oops. Let's delete the
> confusing and impossible NULL check.
Applied 1+2 to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check
2021-06-09 9:26 [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check Dan Carpenter
2021-06-10 3:01 ` Martin K. Petersen
@ 2021-06-16 3:48 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-06-16 3:48 UTC (permalink / raw)
To: Dan Carpenter, James E.J. Bottomley
Cc: Martin K . Petersen, linux-kernel, Hannes Reinecke, Tomas Henzl,
Himanshu Madhani, kernel-janitors, linux-scsi, Kashyap Desai
On Wed, 9 Jun 2021 12:26:02 +0300, Dan Carpenter wrote:
> The "mrioc->intr_info" pointer can't be NULL, but if it could then the
> second iteration through the loop would Oops. Let's delete the
> confusing and impossible NULL check.
Applied to 5.14/scsi-queue, thanks!
[1/2] scsi: mpi3mr: delete unnecessary NULL check
https://git.kernel.org/mkp/scsi/c/d46bdecd9f3c
[2/2] scsi: mpi3mr: Fix error handling in mpi3mr_setup_isr()
https://git.kernel.org/mkp/scsi/c/2938bedd0efa
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-16 3:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 9:26 [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check Dan Carpenter
2021-06-10 3:01 ` Martin K. Petersen
2021-06-16 3:48 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).