* [PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()
@ 2018-03-14 13:40 John Pittman
2018-03-14 13:44 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: John Pittman @ 2018-03-14 13:40 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: linux-kernel, John Pittman
In the comment for function alua_alloc_pg() the argument '@h' is
mistakenly referred to. Fix this by replacing it with the correct
argument reference, '@tpgs', and provide a short description.
Signed-off-by: John Pittman <jpittman@redhat.com>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 4b44325..ab89e42 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -214,8 +214,8 @@ static struct alua_port_group *alua_find_get_pg(char *id_str, size_t id_size,
/*
* alua_alloc_pg - Allocate a new port_group structure
* @sdev: scsi device
- * @h: alua device_handler data
* @group_id: port group id
+ * @tpgs: target port group settings
*
* Allocate a new port_group structure for a given
* device.
--
2.7.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()
2018-03-14 13:40 [PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg() John Pittman
@ 2018-03-14 13:44 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-03-14 13:44 UTC (permalink / raw)
To: John Pittman; +Cc: jejb, martin.petersen, linux-kernel
John,
> In the comment for function alua_alloc_pg() the argument '@h' is
> mistakenly referred to. Fix this by replacing it with the correct
> argument reference, '@tpgs', and provide a short description.
Please submit to linux-scsi@vger.kernel.org. Otherwise the patch won't
get picked up by patchwork.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-14 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-14 13:40 [PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg() John Pittman
2018-03-14 13:44 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).