[mkp-scsi:for-next 31/41] drivers/phy/samsung/phy-fsd-ufs.c:50:3: error: field designator 'cfgs' does not refer to any field in type 'const struct samsung_ufs_phy_drvdata'; did you mean 'cfg'?

[mkp-scsi:for-next 31/41] drivers/phy/samsung/phy-fsd-ufs.c:50:3: error: field designator 'cfgs' does not refer to any field in type 'const struct samsung_ufs_phy_drvdata'; did you mean 'cfg'?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head:   b9f50e3cfd13687279f2170ff6ef5d71f6c7db11
commit: f678ce49991950e4964cd82d3f3a8adfb63a9a70 [31/41] scsi: phy: samsung-ufs: Add support for FSD UFS PHY driver
config: hexagon-randconfig-r045-20220612 (https://download.01.org/0day-ci/archive/20220612/202206120755.03gKC0ne-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project ff4abe755279a3a47cc416ef80dbc900d9a98a19)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=f678ce49991950e4964cd82d3f3a8adfb63a9a70
        git remote add mkp-scsi https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
        git fetch --no-tags mkp-scsi for-next
        git checkout f678ce49991950e4964cd82d3f3a8adfb63a9a70
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/phy/samsung/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/phy/samsung/phy-fsd-ufs.c:50:3: error: field designator 'cfgs' does not refer to any field in type 'const struct samsung_ufs_phy_drvdata'; did you mean 'cfg'?
           .cfgs = fsd_ufs_phy_cfgs,
            ^~~~
            cfg
   drivers/phy/samsung/phy-samsung-ufs.h:104:37: note: 'cfg' declared here
           const struct samsung_ufs_phy_cfg **cfg;
                                              ^
   1 error generated.


vim +50 drivers/phy/samsung/phy-fsd-ufs.c

    48	
    49	const struct samsung_ufs_phy_drvdata fsd_ufs_phy = {
  > 50		.cfgs = fsd_ufs_phy_cfgs,

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

RE: [mkp-scsi:for-next 31/41] drivers/phy/samsung/phy-fsd-ufs.c:50:3: error: field designator 'cfgs' does not refer to any field in type 'const struct samsung_ufs_phy_drvdata'; did you mean 'cfg'?

[Alim Akhtar]

Hi

>-----Original Message-----
>From: kernel test robot [mailto:lkp@intel.com]
>Sent: Sunday, June 12, 2022 5:03 AM
>To: Alim Akhtar <alim.akhtar@samsung.com>
>Cc: llvm@lists.linux.dev; kbuild-all@lists.01.org;
linux-kernel@vger.kernel.org;
>Martin K. Petersen <martin.petersen@oracle.com>; Chanho Park
><chanho61.park@samsung.com>; Bharat Uppal
><bharat.uppal@samsung.com>
>Subject: [mkp-scsi:for-next 31/41] drivers/phy/samsung/phy-fsd-ufs.c:50:3:
>error: field designator 'cfgs' does not refer to any field in type 'const
struct
>samsung_ufs_phy_drvdata'; did you mean 'cfg'?
>
>tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
for-next
>head:   b9f50e3cfd13687279f2170ff6ef5d71f6c7db11
>commit: f678ce49991950e4964cd82d3f3a8adfb63a9a70 [31/41] scsi: phy:
>samsung-ufs: Add support for FSD UFS PHY driver
>config: hexagon-randconfig-r045-20220612
>(https://protect2.fireeye.com/v1/url?k=5d7e4a21-3c05e0a8-5d7fc16e-
>74fe48600034-ee8489beaab56766&q=1&e=4cfcb9fa-8108-4551-8c4c-
>365a83dbb2ae&u=https%3A%2F%2Fdownload.01.org%2F0day-
>ci%2Farchive%2F20220612%2F202206120755.03gKC0ne-
>lkp%40intel.com%2Fconfig)
>compiler: clang version 15.0.0
>(https://protect2.fireeye.com/v1/url?k=2ec17c37-4fbad6be-2ec0f778-
>74fe48600034-5023bd0668516b05&q=1&e=4cfcb9fa-8108-4551-8c4c-
>365a83dbb2ae&u=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project
>ff4abe755279a3a47cc416ef80dbc900d9a98a19)
>reproduce (this is a W=1 build):
>        wget https://protect2.fireeye.com/v1/url?k=0f0eec04-6e75468d-
>0f0f674b-74fe48600034-eda10c46bdf9a9c9&q=1&e=4cfcb9fa-8108-4551-8c4c-
>365a83dbb2ae&u=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Fl
>kp-tests%2Fmaster%2Fsbin%2Fmake.cross -O ~/bin/make.cross
>        chmod +x ~/bin/make.cross
>        #
>https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=f67
>8ce49991950e4964cd82d3f3a8adfb63a9a70
>        git remote add mkp-scsi
>https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
>        git fetch --no-tags mkp-scsi for-next
>        git checkout f678ce49991950e4964cd82d3f3a8adfb63a9a70
>        # save the config file
>        mkdir build_dir && cp config build_dir/.config
>        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross
>W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/phy/samsung/
>
>If you fix the issue, kindly add following tag where applicable
>Reported-by: kernel test robot <lkp@intel.com>
>
>All errors (new ones prefixed by >>):
>
>>> drivers/phy/samsung/phy-fsd-ufs.c:50:3: error: field designator 'cfgs'
does
>not refer to any field in type 'const struct samsung_ufs_phy_drvdata'; did
you
>mean 'cfg'?
>           .cfgs = fsd_ufs_phy_cfgs,
>            ^~~~
>            cfg
>   drivers/phy/samsung/phy-samsung-ufs.h:104:37: note: 'cfg' declared here
>           const struct samsung_ufs_phy_cfg **cfg;
>                

[1] " patch:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220607072907.1
27000-3-chanho61.park@samsung.com/

changes the cfg -> cfgs , and it is merged in Linux-next.
This series was based on next-20220609

I was expecting phy driver changes will go via phy tree, where [1] is
available.

@Martin, can you please take a look?

You can just take the ufs changes (along with its device tree) and drop the
phy change or take the [1] above.


>   1 error generated.
>
>
>vim +50 drivers/phy/samsung/phy-fsd-ufs.c
>
>    48
>    49	const struct samsung_ufs_phy_drvdata fsd_ufs_phy = {
>  > 50		.cfgs = fsd_ufs_phy_cfgs,
>
>--
>0-DAY CI Kernel Test Service
>https://protect2.fireeye.com/v1/url?k=780e3ae5-1975906c-780fb1aa-
>74fe48600034-15b3e78a3eb1d3c6&q=1&e=4cfcb9fa-8108-4551-8c4c-
>365a83dbb2ae&u=https%3A%2F%2F01.org%2Flkp

Re: [mkp-scsi:for-next 31/41] drivers/phy/samsung/phy-fsd-ufs.c:50:3: error: field designator 'cfgs' does not refer to any field in type 'const struct samsung_ufs_phy_drvdata'; did you mean 'cfg'?

[Martin K. Petersen]

Alim,

> I was expecting phy driver changes will go via phy tree, where [1] is
> available.
>
> @Martin, can you please take a look?
>
> You can just take the ufs changes (along with its device tree) and
> drop the phy change or take the [1] above.

Doesn't matter to me, happy to drop the series again. I just queued it
up to see if there would be any warnings.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [mkp-scsi:for-next 31/41] drivers/phy/samsung/phy-fsd-ufs.c:50:3: error: field designator 'cfgs' does not refer to any field in type 'const struct samsung_ufs_phy_drvdata'; did you mean 'cfg'?

[Martin K. Petersen]

> Doesn't matter to me,

What I meant to say was that it is fine with me if you prefer to take
the whole series through the phy tree.

-- 
Martin K. Petersen	Oracle Linux Engineering

RE: [mkp-scsi:for-next 31/41] drivers/phy/samsung/phy-fsd-ufs.c:50:3: error: field designator 'cfgs' does not refer to any field in type 'const struct samsung_ufs_phy_drvdata'; did you mean 'cfg'?

[Alim Akhtar]

Hi Martin

>-----Original Message-----
>From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
>Sent: Tuesday, June 14, 2022 7:15 AM
>To: Alim Akhtar <alim.akhtar@samsung.com>
>Cc: 'kernel test robot' <lkp@intel.com>; llvm@lists.linux.dev; kbuild-
>all@lists.01.org; linux-kernel@vger.kernel.org; 'Martin K. Petersen'
><martin.petersen@oracle.com>; 'Chanho Park'
><chanho61.park@samsung.com>; 'Bharat Uppal'
><bharat.uppal@samsung.com>
>Subject: Re: [mkp-scsi:for-next 31/41] drivers/phy/samsung/phy-fsd-
>ufs.c:50:3: error: field designator 'cfgs' does not refer to any field in
type
>'const struct samsung_ufs_phy_drvdata'; did you mean 'cfg'?
>
>
>Alim,
>
>> I was expecting phy driver changes will go via phy tree, where [1] is
>> available.
>>
>> @Martin, can you please take a look?
>>
>> You can just take the ufs changes (along with its device tree) and
>> drop the phy change or take the [1] above.
>
>Doesn't matter to me, happy to drop the series again. I just queued it up
to
>see if there would be any warnings.
>
No need to drop entire series, as UFS changes has got all Reviewed-by tags.

Just drop patch-{1/6, 2/6 and 3/6} (phy changes)

And please keep patch-{4/6, 5/6 and 6/6} in your tree

Thanks 

>--
>Martin K. Petersen	Oracle Linux Engineering

Re: [mkp-scsi:for-next 31/41] drivers/phy/samsung/phy-fsd-ufs.c:50:3: error: field designator 'cfgs' does not refer to any field in type 'const struct samsung_ufs_phy_drvdata'; did you mean 'cfg'?

[Martin K. Petersen]

Alim,

> Just drop patch-{1/6, 2/6 and 3/6} (phy changes)
>
> And please keep patch-{4/6, 5/6 and 6/6} in your tree

OK, will do!

-- 
Martin K. Petersen	Oracle Linux Engineering