* [PATCH] SCSI: bnx2i: requires MMU
@ 2020-11-29 7:09 Randy Dunlap
2020-12-01 5:32 ` Martin K. Petersen
2020-12-03 20:45 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-11-29 7:09 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, linux-scsi, Nilesh Javali, Manish Rangankar,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen
The SCSI_BNX2_ISCSI kconfig symbol selects CNIC and CNIC selects UIO,
which depends on MMU.
Since 'select' does not follow dependency chains, add the same MMU
dependency to SCSI_BNX2_ISCSI.
Quietens this kconfig warning:
WARNING: unmet direct dependencies detected for CNIC
Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && PCI [=y] && (IPV6 [=m] || IPV6 [=m]=n) && MMU [=n]
Selected by [m]:
- SCSI_BNX2_ISCSI [=m] && SCSI_LOWLEVEL [=y] && SCSI [=y] && NET [=y] && PCI [=y] && (IPV6 [=m] || IPV6 [=m]=n)
Fixes: cf4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-scsi@vger.kernel.org
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Manish Rangankar <mrangankar@marvell.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
---
drivers/scsi/bnx2i/Kconfig | 1 +
1 file changed, 1 insertions(+)
--- linux-next-20201125.orig/drivers/scsi/bnx2i/Kconfig
+++ linux-next-20201125/drivers/scsi/bnx2i/Kconfig
@@ -4,6 +4,7 @@ config SCSI_BNX2_ISCSI
depends on NET
depends on PCI
depends on (IPV6 || IPV6=n)
+ depends on MMU
select SCSI_ISCSI_ATTRS
select NETDEVICES
select ETHERNET
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] SCSI: bnx2i: requires MMU
2020-11-29 7:09 [PATCH] SCSI: bnx2i: requires MMU Randy Dunlap
@ 2020-12-01 5:32 ` Martin K. Petersen
2020-12-03 20:45 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-12-01 5:32 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, linux-scsi, Nilesh Javali, Manish Rangankar,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen
Randy,
> The SCSI_BNX2_ISCSI kconfig symbol selects CNIC and CNIC selects UIO,
> which depends on MMU. Since 'select' does not follow dependency
> chains, add the same MMU dependency to SCSI_BNX2_ISCSI.
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SCSI: bnx2i: requires MMU
2020-11-29 7:09 [PATCH] SCSI: bnx2i: requires MMU Randy Dunlap
2020-12-01 5:32 ` Martin K. Petersen
@ 2020-12-03 20:45 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-12-03 20:45 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Martin K . Petersen, Manish Rangankar, James E.J. Bottomley,
Nilesh Javali, GR-QLogic-Storage-Upstream, linux-scsi
On Sat, 28 Nov 2020 23:09:16 -0800, Randy Dunlap wrote:
> The SCSI_BNX2_ISCSI kconfig symbol selects CNIC and CNIC selects UIO,
> which depends on MMU.
> Since 'select' does not follow dependency chains, add the same MMU
> dependency to SCSI_BNX2_ISCSI.
>
> Quietens this kconfig warning:
>
> [...]
Applied to 5.10/scsi-fixes, thanks!
[1/1] SCSI: bnx2i: requires MMU
https://git.kernel.org/mkp/scsi/c/2d586494c4a0
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-03 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-29 7:09 [PATCH] SCSI: bnx2i: requires MMU Randy Dunlap
2020-12-01 5:32 ` Martin K. Petersen
2020-12-03 20:45 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).