* [PATCH v2] qla2xxx: correctly shift host byte
@ 2018-04-09 12:24 Johannes Thumshirn
2018-04-10 1:17 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Thumshirn @ 2018-04-09 12:24 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Bart Van Assche, Linux Kernel Mailinglist,
Linux SCSI Mailinglist, Johannes Thumshirn
The SCSI host byte has to be shifted by 16 not 6.
As Bart pointed out this patch does not change any functionality
because DID_OK == 0, but a wrong shift is irritating for the reviewer.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
---
Changes to v1:
* Add Bart's review remark, that I'm not changing actual functionality
as DID_OK == 0
drivers/scsi/qla2xxx/qla_isr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 89f93ebd819d..49d67e1d571f 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2368,7 +2368,7 @@ qla25xx_process_bidir_status_iocb(scsi_qla_host_t *vha, void *pkt,
bsg_job->reply_len = sizeof(struct fc_bsg_reply);
/* Always return DID_OK, bsg will send the vendor specific response
* in this case only */
- sp->done(sp, DID_OK << 6);
+ sp->done(sp, DID_OK << 16);
}
--
2.16.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] qla2xxx: correctly shift host byte
2018-04-09 12:24 [PATCH v2] qla2xxx: correctly shift host byte Johannes Thumshirn
@ 2018-04-10 1:17 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-04-10 1:17 UTC (permalink / raw)
To: Johannes Thumshirn
Cc: Martin K . Petersen, Bart Van Assche, Linux Kernel Mailinglist,
Linux SCSI Mailinglist
Johannes,
> The SCSI host byte has to be shifted by 16 not 6.
>
> As Bart pointed out this patch does not change any functionality
> because DID_OK == 0, but a wrong shift is irritating for the reviewer.
Applied to 4.17/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-10 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 12:24 [PATCH v2] qla2xxx: correctly shift host byte Johannes Thumshirn
2018-04-10 1:17 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).