* [PATCH] scsi: tcm_loop: make tcm_loop_lld_bus const
@ 2024-02-04 20:48 Ricardo B. Marliere
2024-02-05 12:46 ` Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ricardo B. Marliere @ 2024-02-04 20:48 UTC (permalink / raw)
To: Martin K. Petersen
Cc: linux-scsi, target-devel, linux-kernel, Greg Kroah-Hartman,
Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type,
move the tcm_loop_lld_bus variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
drivers/target/loopback/tcm_loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
index 8e4035ff3674..761c511aea07 100644
--- a/drivers/target/loopback/tcm_loop.c
+++ b/drivers/target/loopback/tcm_loop.c
@@ -83,7 +83,7 @@ static int tcm_loop_show_info(struct seq_file *m, struct Scsi_Host *host)
static int tcm_loop_driver_probe(struct device *);
static void tcm_loop_driver_remove(struct device *);
-static struct bus_type tcm_loop_lld_bus = {
+static const struct bus_type tcm_loop_lld_bus = {
.name = "tcm_loop_bus",
.probe = tcm_loop_driver_probe,
.remove = tcm_loop_driver_remove,
---
base-commit: 3f90ac7138edb995b4312221647b58afcc15ec06
change-id: 20240204-bus_cleanup-target-5393cf09c658
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: tcm_loop: make tcm_loop_lld_bus const
2024-02-04 20:48 [PATCH] scsi: tcm_loop: make tcm_loop_lld_bus const Ricardo B. Marliere
@ 2024-02-05 12:46 ` Greg Kroah-Hartman
2024-02-06 2:00 ` Martin K. Petersen
2024-02-13 1:57 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-05 12:46 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Martin K. Petersen, linux-scsi, target-devel, linux-kernel
On Sun, Feb 04, 2024 at 05:48:26PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the tcm_loop_lld_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: tcm_loop: make tcm_loop_lld_bus const
2024-02-04 20:48 [PATCH] scsi: tcm_loop: make tcm_loop_lld_bus const Ricardo B. Marliere
2024-02-05 12:46 ` Greg Kroah-Hartman
@ 2024-02-06 2:00 ` Martin K. Petersen
2024-02-13 1:57 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2024-02-06 2:00 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Martin K. Petersen, linux-scsi, target-devel, linux-kernel,
Greg Kroah-Hartman
Ricardo,
> Now that the driver core can properly handle constant struct bus_type,
> move the tcm_loop_lld_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
Applied to 6.9/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: tcm_loop: make tcm_loop_lld_bus const
2024-02-04 20:48 [PATCH] scsi: tcm_loop: make tcm_loop_lld_bus const Ricardo B. Marliere
2024-02-05 12:46 ` Greg Kroah-Hartman
2024-02-06 2:00 ` Martin K. Petersen
@ 2024-02-13 1:57 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2024-02-13 1:57 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Martin K . Petersen, linux-scsi, target-devel, linux-kernel,
Greg Kroah-Hartman
On Sun, 04 Feb 2024 17:48:26 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the tcm_loop_lld_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
>
Applied to 6.9/scsi-queue, thanks!
[1/1] scsi: tcm_loop: make tcm_loop_lld_bus const
https://git.kernel.org/mkp/scsi/c/4ad946536537
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-13 1:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-04 20:48 [PATCH] scsi: tcm_loop: make tcm_loop_lld_bus const Ricardo B. Marliere
2024-02-05 12:46 ` Greg Kroah-Hartman
2024-02-06 2:00 ` Martin K. Petersen
2024-02-13 1:57 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).