* [PATCH] scsi: efct: Fix possible memleak in efct_device_init()
@ 2022-11-11 7:40 Chen Zhongjin
2022-11-26 0:19 ` Martin K. Petersen
2022-12-01 3:45 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Chen Zhongjin @ 2022-11-11 7:40 UTC (permalink / raw)
To: linux-kernel, linux-scsi, target-devel
Cc: james.smart, ram.vegesna, jejb, martin.petersen,
christophe.jaillet, hare, dwagner, chenzhongjin
In efct_device_init(), when efct_scsi_reg_fc_transport() fails,
efct_scsi_tgt_driver_exit() is not called to release memory for
efct_scsi_tgt_driver_init() and causes memleak:
unreferenced object 0xffff8881020ce000 (size 2048):
comm "modprobe", pid 465, jiffies 4294928222 (age 55.872s)
backtrace:
[<0000000021a1ef1b>] kmalloc_trace+0x27/0x110
[<000000004c3ed51c>] target_register_template+0x4fd/0x7b0 [target_core_mod]
[<00000000f3393296>] efct_scsi_tgt_driver_init+0x18/0x50 [efct]
[<00000000115de533>] 0xffffffffc0d90011
[<00000000d608f646>] do_one_initcall+0xd0/0x4e0
[<0000000067828cf1>] do_init_module+0x1cc/0x6a0
...
Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
---
drivers/scsi/elx/efct/efct_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/elx/efct/efct_driver.c b/drivers/scsi/elx/efct/efct_driver.c
index b08fc8839808..49fd2cfed70c 100644
--- a/drivers/scsi/elx/efct/efct_driver.c
+++ b/drivers/scsi/elx/efct/efct_driver.c
@@ -42,6 +42,7 @@ efct_device_init(void)
rc = efct_scsi_reg_fc_transport();
if (rc) {
+ efct_scsi_tgt_driver_exit();
pr_err("failed to register to FC host\n");
return rc;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: efct: Fix possible memleak in efct_device_init()
2022-11-11 7:40 [PATCH] scsi: efct: Fix possible memleak in efct_device_init() Chen Zhongjin
@ 2022-11-26 0:19 ` Martin K. Petersen
2022-12-01 3:45 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-11-26 0:19 UTC (permalink / raw)
To: Chen Zhongjin
Cc: linux-kernel, linux-scsi, target-devel, james.smart, ram.vegesna,
jejb, martin.petersen, christophe.jaillet, hare, dwagner
Chen,
> In efct_device_init(), when efct_scsi_reg_fc_transport() fails,
> efct_scsi_tgt_driver_exit() is not called to release memory for
> efct_scsi_tgt_driver_init() and causes memleak:
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: efct: Fix possible memleak in efct_device_init()
2022-11-11 7:40 [PATCH] scsi: efct: Fix possible memleak in efct_device_init() Chen Zhongjin
2022-11-26 0:19 ` Martin K. Petersen
@ 2022-12-01 3:45 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-12-01 3:45 UTC (permalink / raw)
To: linux-kernel, linux-scsi, target-devel, Chen Zhongjin
Cc: Martin K . Petersen, jejb, christophe.jaillet, hare, ram.vegesna,
dwagner, james.smart
On Fri, 11 Nov 2022 15:40:46 +0800, Chen Zhongjin wrote:
> In efct_device_init(), when efct_scsi_reg_fc_transport() fails,
> efct_scsi_tgt_driver_exit() is not called to release memory for
> efct_scsi_tgt_driver_init() and causes memleak:
>
> unreferenced object 0xffff8881020ce000 (size 2048):
> comm "modprobe", pid 465, jiffies 4294928222 (age 55.872s)
> backtrace:
> [<0000000021a1ef1b>] kmalloc_trace+0x27/0x110
> [<000000004c3ed51c>] target_register_template+0x4fd/0x7b0 [target_core_mod]
> [<00000000f3393296>] efct_scsi_tgt_driver_init+0x18/0x50 [efct]
> [<00000000115de533>] 0xffffffffc0d90011
> [<00000000d608f646>] do_one_initcall+0xd0/0x4e0
> [<0000000067828cf1>] do_init_module+0x1cc/0x6a0
> ...
>
> [...]
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: efct: Fix possible memleak in efct_device_init()
https://git.kernel.org/mkp/scsi/c/bb0cd225dd37
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-01 3:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-11 7:40 [PATCH] scsi: efct: Fix possible memleak in efct_device_init() Chen Zhongjin
2022-11-26 0:19 ` Martin K. Petersen
2022-12-01 3:45 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).