* [PATCH] scsi/megaraid_sas: fix a compilation warning
@ 2019-07-26 14:25 Qian Cai
2019-08-06 3:27 ` Qian Cai
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Qian Cai @ 2019-07-26 14:25 UTC (permalink / raw)
To: martin.petersen
Cc: jejb, kashyap.desai, sumit.saxena, shivasharan.srikanteshwara,
megaraidlinux.pdl, linux-scsi, linux-kernel, Qian Cai
The commit de516379e85f ("scsi: megaraid_sas: changes to function
prototypes") introduced a comilation warning due to it changed the
function prototype of read_fw_status_reg() to take an instance pointer
instead, but forgot to remove an unused variable.
drivers/scsi/megaraid/megaraid_sas_fusion.c: In function
'megasas_fusion_update_can_queue':
drivers/scsi/megaraid/megaraid_sas_fusion.c:326:39: warning: variable
'reg_set' set but not used [-Wunused-but-set-variable]
struct megasas_register_set __iomem *reg_set;
^~~~~~~
Fixes: de516379e85f ("scsi: megaraid_sas: changes to function prototypes")
Signed-off-by: Qian Cai <cai@lca.pw>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index a32b3f0fcd15..e8092d59d575 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -323,9 +323,6 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
{
u16 cur_max_fw_cmds = 0;
u16 ldio_threshold = 0;
- struct megasas_register_set __iomem *reg_set;
-
- reg_set = instance->reg_set;
/* ventura FW does not fill outbound_scratch_pad_2 with queue depth */
if (instance->adapter_type < VENTURA_SERIES)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi/megaraid_sas: fix a compilation warning
2019-07-26 14:25 [PATCH] scsi/megaraid_sas: fix a compilation warning Qian Cai
@ 2019-08-06 3:27 ` Qian Cai
2019-08-06 7:05 ` Sumit Saxena
2019-08-08 1:30 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Qian Cai @ 2019-08-06 3:27 UTC (permalink / raw)
To: martin.petersen
Cc: jejb, Kashyap Desai, Sumit Saxena, shivasharan.srikanteshwara,
megaraidlinux.pdl, linux-scsi, linux-kernel
Ping. Please take a look at this trivial patch.
> On Jul 26, 2019, at 10:25 AM, Qian Cai <cai@lca.pw> wrote:
>
> The commit de516379e85f ("scsi: megaraid_sas: changes to function
> prototypes") introduced a comilation warning due to it changed the
> function prototype of read_fw_status_reg() to take an instance pointer
> instead, but forgot to remove an unused variable.
>
> drivers/scsi/megaraid/megaraid_sas_fusion.c: In function
> 'megasas_fusion_update_can_queue':
> drivers/scsi/megaraid/megaraid_sas_fusion.c:326:39: warning: variable
> 'reg_set' set but not used [-Wunused-but-set-variable]
> struct megasas_register_set __iomem *reg_set;
> ^~~~~~~
> Fixes: de516379e85f ("scsi: megaraid_sas: changes to function prototypes")
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index a32b3f0fcd15..e8092d59d575 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -323,9 +323,6 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
> {
> u16 cur_max_fw_cmds = 0;
> u16 ldio_threshold = 0;
> - struct megasas_register_set __iomem *reg_set;
> -
> - reg_set = instance->reg_set;
>
> /* ventura FW does not fill outbound_scratch_pad_2 with queue depth */
> if (instance->adapter_type < VENTURA_SERIES)
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi/megaraid_sas: fix a compilation warning
2019-07-26 14:25 [PATCH] scsi/megaraid_sas: fix a compilation warning Qian Cai
2019-08-06 3:27 ` Qian Cai
@ 2019-08-06 7:05 ` Sumit Saxena
2019-08-08 1:30 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Sumit Saxena @ 2019-08-06 7:05 UTC (permalink / raw)
To: Qian Cai
Cc: Martin K. Petersen, James E.J. Bottomley, Kashyap Desai,
Shivasharan Srikanteshwara, PDL,MEGARAIDLINUX, Linux SCSI List,
LKML
On Fri, Jul 26, 2019 at 7:55 PM Qian Cai <cai@lca.pw> wrote:
>
> The commit de516379e85f ("scsi: megaraid_sas: changes to function
> prototypes") introduced a comilation warning due to it changed the
> function prototype of read_fw_status_reg() to take an instance pointer
> instead, but forgot to remove an unused variable.
>
> drivers/scsi/megaraid/megaraid_sas_fusion.c: In function
> 'megasas_fusion_update_can_queue':
> drivers/scsi/megaraid/megaraid_sas_fusion.c:326:39: warning: variable
> 'reg_set' set but not used [-Wunused-but-set-variable]
> struct megasas_register_set __iomem *reg_set;
> ^~~~~~~
> Fixes: de516379e85f ("scsi: megaraid_sas: changes to function prototypes")
> Signed-off-by: Qian Cai <cai@lca.pw>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index a32b3f0fcd15..e8092d59d575 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -323,9 +323,6 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
> {
> u16 cur_max_fw_cmds = 0;
> u16 ldio_threshold = 0;
> - struct megasas_register_set __iomem *reg_set;
> -
> - reg_set = instance->reg_set;
>
> /* ventura FW does not fill outbound_scratch_pad_2 with queue depth */
> if (instance->adapter_type < VENTURA_SERIES)
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi/megaraid_sas: fix a compilation warning
2019-07-26 14:25 [PATCH] scsi/megaraid_sas: fix a compilation warning Qian Cai
2019-08-06 3:27 ` Qian Cai
2019-08-06 7:05 ` Sumit Saxena
@ 2019-08-08 1:30 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2019-08-08 1:30 UTC (permalink / raw)
To: Qian Cai
Cc: martin.petersen, jejb, kashyap.desai, sumit.saxena,
shivasharan.srikanteshwara, megaraidlinux.pdl, linux-scsi,
linux-kernel
Qian,
> The commit de516379e85f ("scsi: megaraid_sas: changes to function
> prototypes") introduced a comilation warning due to it changed the
> function prototype of read_fw_status_reg() to take an instance pointer
> instead, but forgot to remove an unused variable.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-08 1:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-26 14:25 [PATCH] scsi/megaraid_sas: fix a compilation warning Qian Cai
2019-08-06 3:27 ` Qian Cai
2019-08-06 7:05 ` Sumit Saxena
2019-08-08 1:30 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).