Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

[Martin K. Petersen]

Can,

You seem to be sending duplicates of almost every mail which makes it
hard for me (and patchwork) to track your series. The mails are
identical except for Message-Id:.

Also, don't resubmit patches just to add Reviewed-by: tags. Patchwork
will pick up the tags. Only resubmit if you are making changes. And if
you do, use -vN to bump the version.

> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
> unique ID by appending the scsi host number to its device name.
>
> Fixes: df032bf27 (scsi: ufs: Add a bsg endpoint that supports UPIUs)

Please use 12-char SHA and enclose commit summary in quotes. See:

	Documentation/process/submitting-patches.rst

Fixes: df032bf27a41 ("scsi: ufs: Add a bsg endpoint that supports UPIUs")

> Signed-off-by: Can Guo <cang@codeaurora.org>
> Reviewed-by: Avri Altman <avri.altman@wdc.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Applied to 5.5/scsi-fixes, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

[PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

[Can Guo]

Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
unique ID by appending the scsi host number to its device name.

Fixes: df032bf27 (scsi: ufs: Add a bsg endpoint that supports UPIUs)
Signed-off-by: Can Guo <cang@codeaurora.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
index dc2f6d2..d2197a3 100644
--- a/drivers/scsi/ufs/ufs_bsg.c
+++ b/drivers/scsi/ufs/ufs_bsg.c
@@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
 	bsg_dev->parent = get_device(parent);
 	bsg_dev->release = ufs_bsg_node_release;
 
-	dev_set_name(bsg_dev, "ufs-bsg");
+	dev_set_name(bsg_dev, "ufs-bsg%u", shost->host_no);
 
 	ret = device_add(bsg_dev);
 	if (ret)
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

RE: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

[Avri Altman]

Hi,
> 
> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an unique
> ID by appending the scsi host number to its device name.
Can you refer me to such a design?

Thanks,
Avri

> 
> Signed-off-by: Can Guo <cang@codeaurora.org>
> 
> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c index
> dc2f6d2..3ef5b78 100644
> --- a/drivers/scsi/ufs/ufs_bsg.c
> +++ b/drivers/scsi/ufs/ufs_bsg.c
> @@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
>         bsg_dev->parent = get_device(parent);
>         bsg_dev->release = ufs_bsg_node_release;
> 
> -       dev_set_name(bsg_dev, "ufs-bsg");
> +       dev_set_name(bsg_dev, "ufs-bsg%d", shost->host_no);
> 
>         ret = device_add(bsg_dev);
>         if (ret)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project

Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

[cang]

On 2019-12-02 15:23, Avri Altman wrote:
> Hi,
>> 
>> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg 
>> an unique
>> ID by appending the scsi host number to its device name.
> Can you refer me to such a design?
> 
> Thanks,
> Avri
> 

Consider a platform which has an embedded UFS device and supports a UFS 
card meanwhile.
This conbination is very popular nowadays. BTW, 845 started supporting 
two UFS hosts 3 years ago.

Thanks,

Can Guo

>> 
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>> 
>> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c 
>> index
>> dc2f6d2..3ef5b78 100644
>> --- a/drivers/scsi/ufs/ufs_bsg.c
>> +++ b/drivers/scsi/ufs/ufs_bsg.c
>> @@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
>>         bsg_dev->parent = get_device(parent);
>>         bsg_dev->release = ufs_bsg_node_release;
>> 
>> -       dev_set_name(bsg_dev, "ufs-bsg");
>> +       dev_set_name(bsg_dev, "ufs-bsg%d", shost->host_no);
>> 
>>         ret = device_add(bsg_dev);
>>         if (ret)
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project

RE: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

[Avri Altman]

 
> 
> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an unique
> ID by appending the scsi host number to its device name.
> 
> Signed-off-by: Can Guo <cang@codeaurora.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

[PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

[Can Guo]

Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
unique ID by appending the scsi host number to its device name.

Signed-off-by: Can Guo <cang@codeaurora.org>

diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
index dc2f6d2..3ef5b78 100644
--- a/drivers/scsi/ufs/ufs_bsg.c
+++ b/drivers/scsi/ufs/ufs_bsg.c
@@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
 	bsg_dev->parent = get_device(parent);
 	bsg_dev->release = ufs_bsg_node_release;
 
-	dev_set_name(bsg_dev, "ufs-bsg");
+	dev_set_name(bsg_dev, "ufs-bsg%d", shost->host_no);
 
 	ret = device_add(bsg_dev);
 	if (ret)
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg

[Christoph Hellwig]

On Mon, Dec 02, 2019 at 03:23:25AM +0000, Can Guo wrote:
> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
> unique ID by appending the scsi host number to its device name.
> 
> Signed-off-by: Can Guo <cang@codeaurora.org>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

This should also get a Fixes: tag so that it gets backported.