linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: megaraid_sas: add in missing white spaces in error messages text
@ 2016-11-12 16:25 Colin King
  2016-11-14 22:24 ` Bart Van Assche
  2016-11-14 23:27 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2016-11-12 16:25 UTC (permalink / raw)
  To: Kashyap Desai, Sumit Saxena, Shivasharan S,
	James E . J . Bottomley, Martin K . Petersen, megaraidlinux.pdl,
	linux-scsi
  Cc: linux-kernel

From: Colin Ian King <colin.king@canonical.com>

A couple of  dev_printk messages spans two lines and the literal string
is missing a white space between words. Add the white space.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index f6db7ab..d8eaf53 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -6788,8 +6788,7 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg)
 	if (atomic_read(&instance->adprecovery) != MEGASAS_HBA_OPERATIONAL) {
 		spin_unlock_irqrestore(&instance->hba_lock, flags);
 
-		dev_err(&instance->pdev->dev, "timed out while"
-			"waiting for HBA to recover\n");
+		dev_err(&instance->pdev->dev, "timed out while waiting for HBA to recover\n");
 		error = -ENODEV;
 		goto out_up;
 	}
@@ -6857,8 +6856,7 @@ static int megasas_mgmt_ioctl_aen(struct file *file, unsigned long arg)
 	spin_lock_irqsave(&instance->hba_lock, flags);
 	if (atomic_read(&instance->adprecovery) != MEGASAS_HBA_OPERATIONAL) {
 		spin_unlock_irqrestore(&instance->hba_lock, flags);
-		dev_err(&instance->pdev->dev, "timed out while waiting"
-				"for HBA to recover\n");
+		dev_err(&instance->pdev->dev, "timed out while waiting for HBA to recover\n");
 		return -ENODEV;
 	}
 	spin_unlock_irqrestore(&instance->hba_lock, flags);
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: megaraid_sas: add in missing white spaces in error messages text
  2016-11-12 16:25 [PATCH] scsi: megaraid_sas: add in missing white spaces in error messages text Colin King
@ 2016-11-14 22:24 ` Bart Van Assche
  2016-11-14 23:27 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2016-11-14 22:24 UTC (permalink / raw)
  To: Colin King, Kashyap Desai, Sumit Saxena, Shivasharan S,
	James E . J . Bottomley, Martin K . Petersen, megaraidlinux.pdl,
	linux-scsi
  Cc: linux-kernel

On 11/12/2016 08:25 AM, Colin King wrote:
> A couple of dev_printk messages spans two lines and the literal string
> is missing a white space between words. Add the white space.

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: megaraid_sas: add in missing white spaces in error messages text
  2016-11-12 16:25 [PATCH] scsi: megaraid_sas: add in missing white spaces in error messages text Colin King
  2016-11-14 22:24 ` Bart Van Assche
@ 2016-11-14 23:27 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-11-14 23:27 UTC (permalink / raw)
  To: Colin King
  Cc: Kashyap Desai, Sumit Saxena, Shivasharan S,
	James E . J . Bottomley, Martin K . Petersen, megaraidlinux.pdl,
	linux-scsi, linux-kernel

>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:

Colin> A couple of dev_printk messages spans two lines and the literal
Colin> string is missing a white space between words. Add the white
Colin> space.

Applied to 4.10/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-14 23:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-12 16:25 [PATCH] scsi: megaraid_sas: add in missing white spaces in error messages text Colin King
2016-11-14 22:24 ` Bart Van Assche
2016-11-14 23:27 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).