* [PATCH] scsi: mvsas: make mvst_host_attrs static
@ 2020-04-15 8:50 Jason Yan
2020-04-17 21:32 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-15 8:50 UTC (permalink / raw)
To: jejb, martin.petersen, yanaijie, rfontana, kstewart, allison,
gregkh, tglx, arnd, linux-scsi, linux-kernel
Cc: Hulk Robot
Fix the following sparse warning:
drivers/scsi/mvsas/mv_init.c:28:25: warning: symbol 'mvst_host_attrs'
was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/mvsas/mv_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index 7af9173c4925..f82728b2c32f 100644
--- a/drivers/scsi/mvsas/mv_init.c
+++ b/drivers/scsi/mvsas/mv_init.c
@@ -25,7 +25,7 @@ static const struct mvs_chip_info mvs_chips[] = {
[chip_1320] = { 2, 4, 0x800, 17, 64, 8, 9, &mvs_94xx_dispatch, },
};
-struct device_attribute *mvst_host_attrs[];
+static struct device_attribute *mvst_host_attrs[];
#define SOC_SAS_NUM 2
@@ -785,7 +785,7 @@ static void __exit mvs_exit(void)
sas_release_transport(mvs_stt);
}
-struct device_attribute *mvst_host_attrs[] = {
+static struct device_attribute *mvst_host_attrs[] = {
&dev_attr_driver_version,
&dev_attr_interrupt_coalescing,
NULL,
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: mvsas: make mvst_host_attrs static
2020-04-15 8:50 [PATCH] scsi: mvsas: make mvst_host_attrs static Jason Yan
@ 2020-04-17 21:32 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-04-17 21:32 UTC (permalink / raw)
To: Jason Yan
Cc: jejb, martin.petersen, rfontana, kstewart, allison, gregkh, tglx,
arnd, linux-scsi, linux-kernel, Hulk Robot
Jason,
> Fix the following sparse warning:
>
> drivers/scsi/mvsas/mv_init.c:28:25: warning: symbol 'mvst_host_attrs'
> was not declared. Should it be static?
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-17 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 8:50 [PATCH] scsi: mvsas: make mvst_host_attrs static Jason Yan
2020-04-17 21:32 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).