From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, x86@kernel.org,
Dmitrii Bundin <dmitrii.bundin.a@gmail.com>,
Fangrui Song <maskray@google.com>,
Alexey Alexandrov <aalexand@google.com>,
Bill Wendling <morbo@google.com>,
Greg Thelen <gthelen@google.com>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: [PATCH 0/3] fix debug info for asm and DEBUG_INFO_SPLIT
Date: Fri, 26 Aug 2022 11:10:32 -0700 [thread overview]
Message-ID: <20220826181035.859042-1-ndesaulniers@google.com> (raw)
Alexey reported that the fraction of unknown filename instances in
kallsyms grew from ~0.3% to ~10% recently; Bill and Greg tracked it down
to assembler defined symbols, which regressed as a result of:
commit b8a9092330da ("Kbuild: do not emit debug info for assembly with LLVM_IAS=1")
In that commit, I allude to restoring debug info for assembler defined
symbols in a follow up patch, but it seems I forgot to do so in
commit a66049e2cf0e ("Kbuild: make DWARF version a choice")
Do so requires a fixup for as-option, which seems to be failing when
used in scripts/Makefile.debug.
Also includes a fix for DEBUG_INFO_SPLIT while I'm here. Dmitrii
reports that this has been broken since gcc-11+ & clang-12+. I'm
guessing no one uses this .config option...since no one else has
reported it being broken yet...
Nick Desaulniers (3):
Makefile.compiler: s/KBUILD_CFLAGS/KBUILD_AFLAGS/ for as-option
Makefile.debug: re-enable debug info for .S files
Makefile.debug: set -g unconditional on CONFIG_DEBUG_INFO_SPLIT
arch/x86/boot/compressed/Makefile | 5 +++--
scripts/Makefile.compiler | 6 +++---
scripts/Makefile.debug | 26 +++++++++++++++++++-------
3 files changed, 25 insertions(+), 12 deletions(-)
--
2.37.2.672.g94769d06f0-goog
next reply other threads:[~2022-08-26 18:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 18:10 Nick Desaulniers [this message]
2022-08-26 18:10 ` [PATCH 1/3] Makefile.compiler: s/KBUILD_CFLAGS/KBUILD_AFLAGS/ for as-option Nick Desaulniers
2022-08-26 18:21 ` Nathan Chancellor
2022-08-26 18:34 ` Nick Desaulniers
2022-08-28 17:20 ` Masahiro Yamada
2022-08-26 18:10 ` [PATCH 2/3] Makefile.debug: re-enable debug info for .S files Nick Desaulniers
2022-08-26 18:41 ` Bill Wendling
2022-08-26 19:52 ` Nick Desaulniers
2022-08-26 20:16 ` Nick Desaulniers
2022-08-26 20:41 ` Bill Wendling
2022-08-26 18:10 ` [PATCH 3/3] Makefile.debug: set -g unconditional on CONFIG_DEBUG_INFO_SPLIT Nick Desaulniers
2022-08-31 17:40 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826181035.859042-1-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=aalexand@google.com \
--cc=dmitrii.bundin.a@gmail.com \
--cc=gthelen@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=michal.lkml@markovi.net \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=trix@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).