From: Song Liu <song@kernel.org>
To: Tom Rix <trix@redhat.com>
Cc: nathan@kernel.org, ndesaulniers@google.com,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v2] md/raid5: remove unused working_disks variable
Date: Tue, 28 Mar 2023 16:17:32 -0700 [thread overview]
Message-ID: <CAPhsuW6=zpRso=5wPUWTPKO+s1Z0Nf09BDpSnb5sKHkEgizbHg@mail.gmail.com> (raw)
In-Reply-To: <20230327132324.1769595-1-trix@redhat.com>
On Mon, Mar 27, 2023 at 6:23 AM Tom Rix <trix@redhat.com> wrote:
>
> clang with W=1 reports
> drivers/md/raid5.c:7719:6: error: variable 'working_disks'
> set but not used [-Werror,-Wunused-but-set-variable]
> int working_disks = 0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied to md-next, with Yu Kuai's Reviewed-by.
Thanks,
Song
> ---
> v2: remove brances
> ---
> drivers/md/raid5.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 7b820b81d8c2..812a12e3e41a 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -7716,7 +7716,6 @@ static void raid5_set_io_opt(struct r5conf *conf)
> static int raid5_run(struct mddev *mddev)
> {
> struct r5conf *conf;
> - int working_disks = 0;
> int dirty_parity_disks = 0;
> struct md_rdev *rdev;
> struct md_rdev *journal_dev = NULL;
> @@ -7912,10 +7911,8 @@ static int raid5_run(struct mddev *mddev)
> pr_warn("md: cannot handle concurrent replacement and reshape.\n");
> goto abort;
> }
> - if (test_bit(In_sync, &rdev->flags)) {
> - working_disks++;
> + if (test_bit(In_sync, &rdev->flags))
> continue;
> - }
> /* This disc is not fully in-sync. However if it
> * just stored parity (beyond the recovery_offset),
> * when we don't need to be concerned about the
> --
> 2.27.0
>
prev parent reply other threads:[~2023-03-28 23:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 13:23 [PATCH v2] md/raid5: remove unused working_disks variable Tom Rix
2023-03-28 23:17 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW6=zpRso=5wPUWTPKO+s1Z0Nf09BDpSnb5sKHkEgizbHg@mail.gmail.com' \
--to=song@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).