From: WEI GAO via ltp <ltp@lists.linux.it>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4] Add PATH to tst_rhost_run.sh
Date: Wed, 11 Jan 2023 14:38:42 -0500 [thread overview]
Message-ID: <20230106113126.5304-1-wegao@suse.com> (raw)
Message-ID: <20230111193842.TM589P3TlSbWB7-mjsL0ccd0NcXXZ5ZZwR0xIVlT40I@z> (raw)
From: coolgw <wegao@suse.com>
When run single test case use command such as:
LTP_SHELL_API_TESTS=shell/net/tst_rhost_run.sh make test-shell
Error msg such as "ns_create: command not found" will popup, so
need update PATH before call ns_create etc..
More important:
1) LTP shell API tests depend on properly compiled LTP.
Therefore this is just a workaround to make visible that some tool is missing.
2) I wonder if there is way to properly fix this dependency in make.
I guess test-shell target should depend on (at least): ns_create ns_exec
ns_ifmove.
Signed-off-by: WEI GAO <wegao@suse.com>
---
v3 -> v4: update base Vorel's latest comments, remove unrelated change
V2 -> V3: move path to test case itself
V1 -> V2: add tst_require_cmds for init_ltp_netspace()
lib/newlib_tests/shell/net/tst_rhost_run.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/newlib_tests/shell/net/tst_rhost_run.sh b/lib/newlib_tests/shell/net/tst_rhost_run.sh
index 773b8dd33..951551514 100755
--- a/lib/newlib_tests/shell/net/tst_rhost_run.sh
+++ b/lib/newlib_tests/shell/net/tst_rhost_run.sh
@@ -3,7 +3,8 @@
# Copyright (c) 2020 Petr Vorel <pvorel@suse.cz>
TST_TESTFUNC=do_test
-PATH="$(dirname $0)/../../../../testcases/lib/:$PATH"
+root="$(dirname $0)/../../../../"
+PATH="$root/testcases/lib/:$root/testcases/kernel/containers/share/:$PATH"
export TST_NET_RHOST_RUN_DEBUG=1
--
2.35.3
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2023-01-12 6:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 11:31 coolgw [this message]
2023-01-10 8:20 ` [LTP] [PATCH v3] Add containers/share to PATH when call init_ltp_netspace Petr Vorel
2023-01-11 10:45 ` [LTP] [PATCH v4] Add PATH to tst_rhost_run.sh coolgw
2023-01-11 17:09 ` WEI GAO via ltp
2023-01-11 19:38 ` WEI GAO via ltp
2023-01-11 19:52 ` WEI GAO via ltp
2023-01-13 9:40 ` Petr Vorel
2023-01-16 11:01 ` Cyril Hrubis
2023-01-17 8:26 ` Petr Vorel
2023-01-17 15:18 ` Wei Gao via ltp
2023-01-26 22:17 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106113126.5304-1-wegao@suse.com \
--to=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).